Hi Michael, I guess the main issue here is that config.h is never actually supposed to be included from a header file in the first place. So it might be best to fix that directly rather than adding ifdefs. Cheers, Jean-Marc On 15/02/17 01:21 PM, Michael Bradshaw wrote:> On Fri, Jan 27, 2017 at 7:39 PM, Michael Bradshaw <mjbshaw at google.com > <mailto:mjbshaw at google.com>> wrote: > > Attached patch adds some missing HAVE_CONFIG_H guards to some places > in celt/arm. Please review. > > > Hi again. Just following up to see if there are any additional changes > that I should make to this patch. Without it, using Ne10 fails to build > without a config.h file present. > > --Michael > > > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus >
On Wed, Feb 15, 2017 at 10:45 AM, Jean-Marc Valin <jmvalin at jmvalin.ca> wrote:> Hi Michael, > > I guess the main issue here is that config.h is never actually supposed > to be included from a header file in the first place. So it might be > best to fix that directly rather than adding ifdefs.Thanks for the response. Attached patch removes the config.h include. I tested by building Ne10 and libopus for both armv7 and arm64. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/opus/attachments/20170215/29d44947/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Remove-include-config.h-from-ARM-Ne10-headers.patch Type: application/octet-stream Size: 925 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/opus/attachments/20170215/29d44947/attachment.obj>
Applied, thanks. Jean-Marc On 15/02/17 02:32 PM, Michael Bradshaw wrote:> On Wed, Feb 15, 2017 at 10:45 AM, Jean-Marc Valin <jmvalin at jmvalin.ca > <mailto:jmvalin at jmvalin.ca>> wrote: > > Hi Michael, > > I guess the main issue here is that config.h is never actually supposed > to be included from a header file in the first place. So it might be > best to fix that directly rather than adding ifdefs. > > > Thanks for the response. Attached patch removes the config.h include. I > tested by building Ne10 and libopus for both armv7 and arm64.