Hello, I've integrated the tests and AVX pitch code into my fork: https://github.com/rvelea/opus/commits/master I ran test_opus_decode and it seems to be running OK. I'll do some more measurements with VTUNE and the new pitch test in the following days and get back to you with a pull request and the data. In the meantime if you have time to give it a quick look and maybe point out any errors or problems at this stage I'd greatly appreciate it. Thanks, Radu -----Original Message----- From: opus-bounces at xiph.org [mailto:opus-bounces at xiph.org] On Behalf Of Timothy B. Terriberry Sent: Thursday, November 5, 2015 11:24 AM To: opus at xiph.org Subject: Re: [opus] AVX Optimizations Velea, Radu wrote:> Sorry. I missed that. Good observation. > Please go ahead and correct the patch.Pushed: https://git.xiph.org/?p=opus.git;a=commitdiff;h=bb0e1e0d6f6b https://git.xiph.org/?p=opus.git;a=commitdiff;h=1632152b83b8 _______________________________________________ opus mailing list opus at xiph.org http://lists.xiph.org/mailman/listinfo/opus
Velea, Radu wrote:> In the meantime if you have time to give it a quick look and maybe point out any errors or problems at this stage I'd greatly appreciate it.I took a brief look and didn't see any obvious bugs, but we will want you to organize the commits so that each one is independently compilable and testable (and doesn't break anything) before you submit them. I understand what you've got up now is just a WIP, though. I'll try to go over them more thoroughly in the next few days.
Hello, Thanks for the feedback. I'll break the current code across multiple commits: first I'll add the pitch float test[1] and then update it as I' add the avx functions one by one. Thanks, Radu [1] https://github.com/xiph/opus/pull/5 -----Original Message----- From: opus-bounces at xiph.org [mailto:opus-bounces at xiph.org] On Behalf Of Timothy B. Terriberry Sent: Saturday, November 7, 2015 2:03 AM To: opus at xiph.org Subject: Re: [opus] AVX Optimizations Velea, Radu wrote:> In the meantime if you have time to give it a quick look and maybe point out any errors or problems at this stage I'd greatly appreciate it.I took a brief look and didn't see any obvious bugs, but we will want you to organize the commits so that each one is independently compilable and testable (and doesn't break anything) before you submit them. I understand what you've got up now is just a WIP, though. I'll try to go over them more thoroughly in the next few days. _______________________________________________ opus mailing list opus at xiph.org http://lists.xiph.org/mailman/listinfo/opus