openssh bugs - Jun 2023 - [Bug 3580] New: ssh-keygen -l: "no comment" never appears again after the first comment

https://bugzilla.mindrot.org/show_bug.cgi?id=3580

            Bug ID: 3580
           Summary: ssh-keygen -l: "no comment" never appears again
after
                    the first comment
           Product: Portable OpenSSH
           Version: 9.3p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: Markus.Kuhn at cl.cam.ac.uk

When running ssh-keygen -l on an input file that contains both public
keys with and without comment, then the indicator "no comment" never
appears again after the first comment. This is because in
do_fingerprint() the variable "comment" is initialized to NULL only
once at the start of the function, but it must actually be
re-initialized for each line read.

For instructions on how to reproduce this bug, as well as a patch for
the very simple and obvious fix, please see my pull-request at

  https://github.com/openssh/openssh-portable/pull/407

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3580

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Applied - thanks. I did see this on github, but was just slow - you
don't generally need to file them in both places, so sorry for making
you do the extra step :(

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3580

--- Comment #2 from Markus Kuhn <Markus.Kuhn at cl.cam.ac.uk> ---
Thanks. I had consulted https://www.openssh.com/report.html for what
the correct procedure is to submit a bug report and patch. Since I
didn't see there https://github.com/openssh/openssh-portable/pulls
mentioned as an option, I thought I'd better raise it here as well.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.