search for: do_fingerprint

http://bugzilla.mindrot.org/show_bug.cgi?id=1319 Summary: ssh-keygen does not properly handle multiple keys Product: Portable OpenSSH Version: 4.5p1 Platform: Other OS/Version: All Status: NEW Severity: normal Priority: P2 Component: ssh-keygen AssignedTo: bitbucket at mindrot.org

...Assignee: unassigned-bugs at mindrot.org Reporter: Markus.Kuhn at cl.cam.ac.uk When running ssh-keygen -l on an input file that contains both public keys with and without comment, then the indicator "no comment" never appears again after the first comment. This is because in do_fingerprint() the variable "comment" is initialized to NULL only once at the start of the function, but it must actually be re-initialized for each line read. For instructions on how to reproduce this bug, as well as a patch for the very simple and obvious fix, please see my pull-request at https...

...gen.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff -uprN openssh-4.3p2/ssh-keygen.c openssh-4.3p2-kylie/ssh-keygen.c --- openssh-4.3p2/ssh-keygen.c 2005-11-28 20:10:25.000000000 -0600 +++ openssh-4.3p2-kylie/ssh-keygen.c 2006-05-03 16:23:38.000000000 -0500 @@ -485,8 +485,10 @@ do_fingerprint(struct passwd *pw) xfree(fp); exit(0); } - if (comment) + if (comment) { xfree(comment); + comment = NULL; + } f = fopen(identity_file, "r"); if (f != NULL) {

...g[i]); + f = fopen(cert_fn, "w"); + if (f == NULL) { + fprintf(stderr, "fopen: %s: %s\n", cert_fn, strerror(errno)); + exit(1); + } + fprintf(f, "%s", dat); + fclose(f); + printf("Certificate has been saved in %s.\n", cert_fn); + exit(0); +} + +static void do_fingerprint(struct passwd *pw) { FILE *f; @@ -1026,6 +1164,7 @@ fprintf(stderr, " -R hostname Remove host from known_hosts file.\n"); fprintf(stderr, " -r hostname Print DNS resource record.\n"); fprintf(stderr, " -S start Start point (hex) for generating DH-GEX moduli.\...