openssh bugs - Apr 2013 - [Bug 2086] New: passwd struct does not have pw_gecos member on Android

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

            Bug ID: 2086
           Summary: passwd struct does not have pw_gecos member on Android
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nathan.osman at gmail.com

Created attachment 2232
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2232&action=edit
adds definition for HAVE_PW_GECOS_IN_PASSWD where appropriate

The passwd struct in Android does not have a pw_gecos member, causing
the following error message when cross-compiling:

  auth.c:724:30: error: 'struct passwd' has no member named
'pw_gecos'

The attached patch adds a check for this member in the configure.ac
file and wraps all assignments to this member with #ifdef / #endif.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
   Attachment #2237|                            |ok?(dtucker at zip.com.au)
              Flags|                            |

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 2237
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2237&action=edit
Tweak autoconf detection

This uses AC_CHECK_MEMBER() to detect it instead of AC_COMPILE_IFELSE()

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2237
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2237
Tweak autoconf detection
>+AC_CHECK_MEMBER([struct passwd.pw_gecos], [AC_DEFINE(
Why not use the stock AC_CHECK_MEMBERS() macro?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2237|ok?(dtucker at zip.com.au)     |
              Flags|                            |
   Attachment #2249|                            |ok?(dtucker at zip.com.au)
              Flags|                            |
   Attachment #2232|0                           |1
        is obsolete|                            |
   Attachment #2237|0                           |1
        is obsolete|                            |

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Created attachment 2249
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2249&action=edit
use AC_CHECK_MEMBERS for all struct passwd member checks

We actually have a few more struct passwd members that should be tested
for using AC_CHECK_MEMBERS, so this cuts them all over.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2249
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2249
use AC_CHECK_MEMBERS for all struct passwd member checks

diff looks OK, however you might want to check with tim if there's a
reason it's done that way.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2249|ok?(dtucker at zip.com.au)     |
              Flags|                            |
   Attachment #2249|0                           |1
        is obsolete|                            |

--- Comment #5 from Tim Rice <tim at multitalents.net> ---
Created attachment 2251
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2251&action=edit
configure.ac tweeks

The patch (2249) was mostly OK. I had to rework configure.ac to keep
shell errors like this from showing up.
..........
checking for
      struct passwd.pw_gecos,... /opt/src/networking/openssh/
openssh/configure: line 2173: ${+:}: bad substitution
/opt/src/networking/openssh/openssh/configure: line 2208: =no: command
not found
........

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2251|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #2251|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2251|                            |ok+
              Flags|                            |

--- Comment #6 from Darren Tucker <dtucker at zip.com.au> ---
Comment on attachment 2251
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2251
configure.ac tweeks

works for me (I see the change in config.h and get identical binaries)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
             Blocks|                            |2076

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Committed - will be in openssh-6.3. Thanks!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2086

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.