openssh bugs - Apr 2013 - [Bug 2085] New: fd_mask and howmany are not defined in Android

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

            Bug ID: 2085
           Summary: fd_mask and howmany are not defined in Android
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nathan.osman at gmail.com

Created attachment 2230
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2230&action=edit
adds appropriate definitions when cross-compiling for Android

This is the first of a few patches that I will be submitting - I am
attempting to get OpenSSH to cross-compile for the Android platform.

Android does not define fd_mask or howmany - and therefore
channels.c:2143 and channels.c:2145 cause compilation to fail with
errors:

  channels.c: In function 'channel_prepare_select':
  channels.c:2143:2: warning: implicit declaration of function
'howmany' [-Wimplicit-function-declaration]
  channels.c:2145:45: error: 'fd_mask' undeclared (first use in this
function)

The attached patch adds a couple of definitions that will work around
this problem.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Nathan Osman <nathan.osman at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2230|0                           |1
        is obsolete|                            |

--- Comment #1 from Nathan Osman <nathan.osman at gmail.com> ---
Created attachment 2231
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2231&action=edit
adds appropriate definitions when cross-compiling for Android [fixed]

Sorry, there was a formatting bug with the original patch - this one
replaces it.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Nathan Osman <nathan.osman at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2231|0                           |1
        is obsolete|                            |

--- Comment #2 from Nathan Osman <nathan.osman at gmail.com> ---
Created attachment 2235
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2235&action=edit
adds appropriate definitions when cross-compiling for Android [fixed
again]

Sorry, I'm having a bad day. I forgot the ';;' at the end of the
androideabi section. This corrected patch should fix everything (I
hope).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Nathan Osman <nathan.osman at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2235|0                           |1
        is obsolete|                            |

--- Comment #3 from Nathan Osman <nathan.osman at gmail.com> ---
Created attachment 2236
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2236&action=edit
adds appropriate definitions when cross-compiling for Android [fixed
yet again]

This is terribly embarrassing - but this time I've started from a
completely clean copy of the source code and applied the patch. I've
gone to great lengths to ensure you won't see any errors this time
around.

THIS ONE SHOULD WORK.

Sorry for being a nuisance.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2076

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Thanks, we'll put this on the list for the 6.3 release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #2276|                            |ok?(djm at mindrot.org)
              Flags|                            |
   Attachment #2236|0                           |1
        is obsolete|                            |

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2276
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2276&action=edit
add real configure tests for NFDBITS, howmany and fd_mask

Rather than continuing to propagate these platform-specific settings I
think we should make them real tests so that we don't have to do this
again.  Does this work for you? (note you'll need to run
"autoreconf"
to rebuild configure before running it).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2276|ok?(djm at mindrot.org)        |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tim at multitalents.net
   Attachment #2276|0                           |1
        is obsolete|                            |

--- Comment #6 from Tim Rice <tim at multitalents.net> ---
Created attachment 2278
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2278&action=edit
tests for NFDBITS, howmany and fd_mask take 2

A good start.
I needed to add sysmacros.h to find howmany on SVR5 platforms.
fd_mask is a typedef so we need to use AC_CHECK_TYPES

Other than that, it's OK

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2278|0                           |1
        is obsolete|                            |

--- Comment #7 from Tim Rice <tim at multitalents.net> ---
Created attachment 2279
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2279&action=edit
tests for NFDBITS, howmany and fd_mask take 3

Opps, uploaded the wrong one before.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

--- Comment #8 from Nathan Osman <nathan.osman at gmail.com> ---
I tried applying your patch but now I get undefined reference to
'howmany' errors again:

  in function ssh_connect:sshconnect.c:270: error: undefined reference
to 'howmany'
  in function ssh_exchange_identification:sshconnect.c:468: error:
undefined reference to 'howmany'
  in function channel_prepare_select:channels.c:2143: error: undefined
reference to 'howmany'
  in function packet_write_wait:packet.c:1734: error: undefined
reference to 'howmany'

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

--- Comment #9 from Nathan Osman <nathan.osman at gmail.com> ---
I think I found the source of the problem. In config.h.in, the
definition names missed getting updated. I am attaching a supplementary
patch that fixes this.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

--- Comment #10 from Nathan Osman <nathan.osman at gmail.com> ---
Created attachment 2282
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2282&action=edit
Fixes improper definition names in config.h.in

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

--- Comment #11 from Tim Rice <tim at multitalents.net> ---
(In reply to Nathan Osman from comment #10)
> Created attachment 2282 [details]
> Fixes improper definition names in config.h.in
As Darren mentioned in comment 5, you need to run autoreconf.
config.h.in is regenerated with the new bits by autoreconf.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

--- Comment #12 from Nathan Osman <nathan.osman at gmail.com> ---
Sorry for the mixup - I was running 'autoconf' instead of
'autoreconf'.
Tim's patch works as-is now and you can ignore my supplementary patch.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Darren Tucker <dtucker at zip.com.au> ---
Patch applied, thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2085

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.