openssh bugs - Apr 2013 - [Bug 2087] New: endgrent() is not available on Android

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

            Bug ID: 2087
           Summary: endgrent() is not available on Android
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: nathan.osman at gmail.com

Created attachment 2233
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2233&action=edit
wraps call to endgrent with HAVE_ENDGRENT and checks for function in
configure.ac

Android does not provide the endgrent() function, leading to the
following compilation error:

  session.c:1502:20: warning: implicit declaration of function
'endgrent'

The attached patch adds endgrent to the list of functions that
configure.ac checks for and wraps the call to endgrent() in session.c
with a #ifdef / #endif.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2234
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2234&action=edit
add an empty endgrent in compat library

#ifdefs in the main codebase are an ongoing maintenance burden, since
they cause diffs from openbsd's ssh to no longer apply, so we try to
avoid this when possible.

instead, I'd put a no-op implementation of endgrent in the compat
library.  I think this patch should work (can you confirm)?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

--- Comment #2 from Nathan Osman <nathan.osman at gmail.com> ---
I have applied your patch and can confirm that it eliminates the error.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2234|                            |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2076

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
Thanks.  We'll put it on the list for the 6.3 release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Patch applied, will be in 6.3p1.  Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2087

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.