openssh bugs - Aug 2009 - [Bug 1628] New: /var/run/sshd.pid file collisions...

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

           Summary: /var/run/sshd.pid file collisions...
           Product: Portable OpenSSH
           Version: 5.2p1
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: mike.ellis at fmr.com


If I install sshd (using the SMF manifest) option and want to run it on
a different port (say for some chroot/sftp action) I end up generating
pid-file collisions between the existing SMF_managed Solaris-SSHd.

making the following change in: /lib/svc/method/site/opensshd
PIDFILE=$piddir/opensshd.pid

does NOT appear to solve the problem. (that PIDFILE variable seems to
be entirely ignored)

--

doing the following in the config-file DOES solve the pid-issue...

/opt/OpenSSH//etc/sshd_config

    PidFile /var/run/opensshd.pid

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org,
                   |                            |tim at multitalents.net

--- Comment #1 from Damien Miller <djm at mindrot.org> 2009-11-20 11:34:57
EST ---
Tim, you know more about SMF that I do - could you please take a look
at this?

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

--- Comment #2 from Tim Rice <tim at multitalents.net> 2009-11-20 16:38:51
EST ---
Created an attachment (id=1726)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1726)
Use PidFile if set in sshd_config

This is not really a SMF issue. The problem is our start/stop script
does not know if PidFile is set in sshd_config.

The attached patch would be one way to address this issue.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

--- Comment #3 from Damien Miller <djm at mindrot.org> 2009-11-20 16:57:52
EST ---
(From update of attachment 1726)
>--- openssh/opensshd.init.in.old	2006-01-31 08:00:37.000000000 -0800
>+++ openssh/opensshd.init.in	2009-11-19 21:27:44.657360000 -0800
>@@ -14,6 +14,8 @@
> 
> SSHD=$prefix/sbin/sshd
> PIDFILE=$piddir/sshd.pid
>+PidFile=`grep "^PidFile " ${sysconfdir}/sshd_config | awk
'{print $2}'`
I don't think this will cope '=' as a config separator, which is
legal
sshd_config syntax:

PidFile=/somewhere/sshd.pid

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

--- Comment #4 from Tim Rice <tim at multitalents.net> 2009-11-21 12:03:21
EST ---
Created an attachment (id=1730)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1730)
take 2

(In reply to comment #3)
> (From update of attachment 1726 [details])
> >+PidFile=`grep "^PidFile " ${sysconfdir}/sshd_config | awk
'{print $2}'`
> 
> I don't think this will cope '=' as a config separator, which
is legal
> sshd_config syntax:
> 
> PidFile=/somewhere/sshd.pid
Good point. This one will.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

--- Comment #5 from Tim Rice <tim at multitalents.net> 2009-11-21 12:09:17
EST ---
Created an attachment (id=1731)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1731)
take 3

Oh rats. take2 handled all cases except the one djm mentioned.

OK, this one really works.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1726|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1730|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1731|                            |ok+
               Flag|                            |

--- Comment #6 from Darren Tucker <dtucker at zip.com.au> 2009-11-21
13:32:54 EST ---
(From update of attachment 1731)
looks good, do it!

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Tim Rice <tim at multitalents.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Tim Rice <tim at multitalents.net> 2009-11-21 14:37:22
EST ---
(In reply to comment #6)
> (From update of attachment 1731 [details])
> looks good, do it!
OK, I've commited the patch. It should show up in a snapshot shortly
and
will be in 5.4. Marking this bug resolved.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1626

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1628

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Darren Tucker <dtucker at zip.com.au> 2010-03-26
10:51:52 EST ---
With the release of 5.4p1, this bug is now considered closed.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.