openssh bugs - Feb 2009 - [Bug 1562] New: EXPAND_MAX_KEYS in percent_expand is actually (EXPAND_MAX_KEYS - 1)

https://bugzilla.mindrot.org/show_bug.cgi?id=1562

           Summary: EXPAND_MAX_KEYS in percent_expand is actually
                    (EXPAND_MAX_KEYS - 1)
           Product: Portable OpenSSH
           Version: 5.2p1
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: minor
          Priority: P4
         Component: Miscellaneous
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: Jan.Pechanec at Sun.COM


Created an attachment (id=1607)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1607)
suggested patch

it may be a nit picking: EXPAND_MAX_KEYS, as any MAX macro, suggests
that we can have up to EXPAND_MAX_KEYS keys. That's not true since if
we reach the maximum, the following test bails out:

        if (num_keys >= EXPAND_MAX_KEYS)
                fatal("percent_expand: too many keys");

it's not a problem here since 16 becomes 15 which is still large enough
but the issue is there anyway. I'm attaching a patch. In the patch
changes, two "==" strings can be changed to ">=" if you
feel it's
better in terms of possible future updates. However, "==" is enough
there.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1562


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1626


-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1562

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> 2009-11-20 14:24:23
EST ---
patch applied, will be in openssh-5.4

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1562

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> 2010-03-26
10:51:23 EST ---
With the release of 5.4p1, this bug is now considered closed.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.