openssh bugs - Oct 2007 - [Bug 1377] New: getpwuid called twice without pwcopy (percent_expand: NULL replacement)

https://bugzilla.mindrot.org/show_bug.cgi?id=1377

           Summary: getpwuid called twice without pwcopy (percent_expand:
                    NULL replacement)
    Classification: Unclassified
           Product: Portable OpenSSH
           Version: 4.4p1
          Platform: ix86
        OS/Version: Mac OS X
            Status: NEW
          Severity: major
          Priority: P2
         Component: ssh
        AssignedTo: bitbucket at mindrot.org
        ReportedBy: toby at butzon.com


Created an attachment (id=1364)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1364)
patch for ssh.c

The symptom is:

$ ssh foo
percent_expand: NULL replacement

Just need to pwcopy the last getpwuid result; percent_expand calls
getpwuid, too, so not doing so destroys the old pwcopy data.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1377





--- Comment #1 from Toby Butzon <toby at butzon.com>  2007-10-20 14:19:51
---
(In reply to comment #0)
> Just need to pwcopy the last getpwuid result; percent_expand calls
> getpwuid, too, so not doing so destroys the old pwcopy data.
Woops, it's not percent_expand, it's tilde_expand_filename.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1377


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bitbucket at mindrot.org       |djm at mindrot.org
Attachment #1364 is|0                           |1
           obsolete|                            |
   Attachment #1379|                            |ok?
               Flag|                            |




--- Comment #2 from Damien Miller <djm at mindrot.org>  2007-11-03
11:37:55 ---
Created an attachment (id=1379)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1379)
free passwd struct after dup

That patch will leak the passwd struct, so I think it needs a symmetric
pwfree() like this.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1377


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.4p1                       |-current
           Platform|ix86                        |All
         OS/Version|Mac OS X                    |All
           Keywords|                            |patch
           Severity|major                       |normal
             Blocks|                            |1353




-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1377


Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
                 CC|                            |dtucker at zip.com.au




--- Comment #3 from Darren Tucker <dtucker at zip.com.au>  2007-12-28
03:09:38 ---
This has been fixed by saving only pw_name and pw_dir (ssh.c revs 1.306
and 1.307), which will be in the 4.8 release.

Thanks for the report.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1377


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added                       
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED                      




--- Comment #4 from Damien Miller <djm at mindrot.org>  2008-03-31
15:22:02 ---
Fix shipped in 4.9/4.9p1 release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.