bugzilla-daemon at bugzilla.mindrot.org
2009-Feb-25 19:33 UTC
[Bug 1563] New: USE_PIPES unconditionally set in session.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1563 Summary: USE_PIPES unconditionally set in session.c Product: Portable OpenSSH Version: 5.2p1 Platform: Other OS/Version: Other Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: unassigned-bugs at mindrot.org ReportedBy: res at qoxp.net In this commit: http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/session.c?rev=1.238;content-type=text%2Fx-cvsweb-markup ... the USE_PIPES code was unconditionally turned on with an explicit "#define USE_PIPES". This makes it impossible to turn off via the normal configuration mechanism (configure.ac). Actually, it might be a good idea to add a configure option for this (configure --with-pipes), since there are tradeoffs involved in its use: the shutdown-read/SIGPIPE behavior verses the problem of some bash versions reading .bashrc and some not. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2009-Feb-26 12:37 UTC
[Bug 1563] USE_PIPES unconditionally set in session.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1563 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |djm at mindrot.org --- Comment #1 from Damien Miller <djm at mindrot.org> 2009-02-26 23:37:06 --- We use pipes in session.c to support the "half-closed for reading" extension (see http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/PROTOCOL?rev=1.12;content-type=text%2Fx-cvsweb-markup;ln=1#l34) since socketpairs don't reliably provide the signalling that we need on all OS's. bash's behaviour has been incorrect pretty much all along; pipes vs. socketpairs has been a per-platform decision in OpenSSH for some years. IMO it would be better to fix bash. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2010-Jun-18 03:13 UTC
[Bug 1563] USE_PIPES unconditionally set in session.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1563 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME --- Comment #2 from Damien Miller <djm at mindrot.org> --- It looks like most Linux distributions are shipping fixed bash by now, so I'll close this bug. -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2011-Jan-24 01:33 UTC
[Bug 1563] USE_PIPES unconditionally set in session.c
https://bugzilla.mindrot.org/show_bug.cgi?id=1563 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Damien Miller <djm at mindrot.org> 2011-01-24 12:33:39 EST --- Move resolved bugs to CLOSED after 5.7 release -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug.