openssh bugs - Jun 2007 - [Bug 1208] ssh fails to remove control socket when ssh is abnormally terminated

http://bugzilla.mindrot.org/show_bug.cgi?id=1208


Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bitbucket at mindrot.org       |djm at mindrot.org




--- Comment #17 from Damien Miller <djm at mindrot.org>  2007-06-22
13:50:53 ---
Created an attachment (id=1309)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=1309)
Delay start of listen on multiplex control socket

In response to comment #16:

This patch should fix your problem - can you verify?


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1208


Daniel Black <dragonheart at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dragonheart at gentoo.org




--- Comment #18 from Daniel Black <dragonheart at gentoo.org>  2007-06-22
18:25:03 ---
Not enough sorry.
The below example used OpenSSH_4.6p1 with the attached patch
A ssh connection was made (and a control socket was created). The ssh
connection was killed with a kill -9 from another terminal. An attempt
to reconnect was made and this failed as per below:

localhost $ ssh devgentoo
Enter passphrase for key '/home/dan/.ssh/id_dsa':
Last login: Fri Jun 22 08:05:10 2007 from 59.167.43.249
HP ProLiant DL380 G5 Server
dragonheart at woodpecker ~ $ Killed

localhost ~ $ ssh devgentoo
Control socket
connect(/home/dan/.ssh/master-dragonheart at dev.gentoo.org:22):
Connection refused
Enter passphrase for key '/home/dan/.ssh/id_dsa':
ControlSocket /home/dan/.ssh/master-dragonheart at dev.gentoo.org:22
already exists

localhost ~ $ ssh -v
OpenSSH_4.6p1, OpenSSL 0.9.8d 28 Sep 2006

Recommendation:
a) delete the control socket when a connection refused occurs (the
connection obviously isn't much use anyway)

I'm not sure of all the things that could cause a connection refused
but given its local I don't think there would be too many options.

b) create a different socket name if you get a "already exists" error
like maketemp though a) would be easier.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1208





--- Comment #19 from Darren Tucker <dtucker at zip.com.au>  2007-06-22
19:35:29 ---
(In reply to comment #18)
> Recommendation:
> a) delete the control socket when a connection refused occurs (the
> connection obviously isn't much use anyway)
I don't think that's a the right thing to do.  You'll get a
connection
refused if the agent has reached its listen backlog limit (eg if you
have a bunch of clients attempting to access it all in quick
succession) but in that case it's just a temporary condition.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

http://bugzilla.mindrot.org/show_bug.cgi?id=1208





--- Comment #20 from Daniel Black <dragonheart at gentoo.org>  2007-06-22
21:40:18 ---
ah thought there must of been a reason you didn't delete it.

How about making the 'already exists' on an attempted reconnection a
warning and fall back to a new connection?


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.