search for: controlsocket

...195,7 @@ muxserver_listen(void) close(muxserver_sock); muxserver_sock = -1; } + xfree(orig_control_path); xfree(options.control_path); options.control_path = NULL; options.control_master = SSHCTL_MASTER_NO; @@ -1216,7 +1217,6 @@ muxserver_listen(void) } error("ControlSocket %s already exists, disabling multiplexing", orig_control_path); - xfree(orig_control_path); unlink(options.control_path); goto disable_mux_master; } -- 1.7.9.rc0.542.g07ca1

http://bugzilla.mindrot.org/show_bug.cgi?id=1329 Summary: stale control sockets prevent connection. Product: Portable OpenSSH Version: 4.6p1 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: ssh AssignedTo: bitbucket at mindrot.org ReportedBy: dwmw2 at

Cheers, - Salva $ diff -c mux.c~ mux.c *** mux.c~ 2008-06-14 01:01:54.000000000 +0200 --- mux.c 2008-12-04 12:24:45.000000000 +0100 *************** *** 148,153 **** --- 148,154 ---- error("ControlSocket %s already exists, " "disabling multiplexing", options.control_path); close(muxserver_sock); + umask(old_umask); muxserver_sock = -1; xfree(options.control_path); options.control_path = NULL;

http://bugzilla.mindrot.org/show_bug.cgi?id=1208 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bitbucket at mindrot.org |djm at mindrot.org --- Comment #17 from Damien

...socket"); memset(&addr, '\0', sizeof(addr)); addr.sun_family = AF_UNIX; @@ -1073,11 +1074,9 @@ old_umask = umask(0177); if (bind(control_fd, (struct sockaddr *)&addr, addr_len) == -1) { control_fd = -1; - if (errno == EINVAL || errno == EADDRINUSE) - fatal("ControlSocket %s already exists", - options.control_path); - else + if (errno != EINVAL && errno != EADDRINUSE) fatal("%s bind(): %s", __func__, strerror(errno)); + return 0; } umask(old_umask); @@ -1085,6 +1084,9 @@ fatal("%s listen(): %s", __func__, strerr...

...localmachine->remoteaccount at remotemachine:22= if now user2 on localmachine tries the same, he gets an error message > user2 at localmachine ~ % ssh remoteaccount at remotemachine > Control socket connect(/tmp/localmachine->remoteaccount at remotemachine:22): Permission denied > ControlSocket /tmp/localmachine->remoteaccount at remotemachine:22 already exists because user1 owns a connection sharing socket of that name already. If one could use %u in ControlPath's argument, sockets would look like > localmachine ~ # ls -l /tmp > srw------- 1 user1 user1 0 19. Apr 14:06 use...

(Second try to send this. I wonder if the first one gotten eaten by a spam filter; I'll link to patches instead of attaching them.) Here are the tincctl patches I've been working on. They apply to http://www.tinc-vpn.org/svn/tinc/branches/1.1@1545. I intend to commit them once the crypto stuff's fixed. Since they're basically done, I'm emailing them now for review and in case

...void +mux_master_session_cleanup_cb(int cid, void *unused) +{ + Channel *cc, *c = channel_by_id(cid); - old_umask = umask(0177); - if (bind(muxserver_sock, (struct sockaddr *)&addr, addr.sun_len) == -1) { - muxserver_sock = -1; - if (errno == EINVAL || errno == EADDRINUSE) { - error("ControlSocket %s already exists, " - "disabling multiplexing", options.control_path); - close(muxserver_sock); - muxserver_sock = -1; - xfree(options.control_path); - options.control_path = NULL; - options.control_master = SSHCTL_MASTER_NO; - return; - } else - fatal("%s...