openssh bugs - May 2005 - [Bug 1029] SIGTERM and cleanup of wtmp files

http://bugzilla.mindrot.org/show_bug.cgi?id=1029

           Summary: SIGTERM and cleanup of wtmp files
           Product: Portable OpenSSH
           Version: 4.0p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: senthilkumar_sen at hotpop.com


SSH is not cleaning up the wtmp files when SIGTERM is passed to user session 
process with Privilegeseparation disabled.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1029





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-04
02:23 -------
Created an attachment (id=895)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=895&action=view)
SIGTERM handler for user sshd process

The attached patch handles the SIGTERM to cleanup the wtmp files with
privilegeseparation disabled.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1029





------- Additional Comments From dtucker at zip.com.au  2005-05-05 20:30 -------
Created an attachment (id=897)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=897&action=view)
cleanup with less code in signal handler

It's generally a bad idea to do too much in signal handlers since it's
prone to
races.	(Some of the existing handlers break this rule, but we shouldn't add
any more, and should fix the existing ones if possible.)

Does the attached patch solve the problem?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1029





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-06
19:36 -------
The attachment id 897 is not cleaning the wtmp entries when SIGTERM is issued to
user session process (Priv sep=no). My understanding is that, for Priv sep no, 
shell pid is logged for utmp/wtmp in OpenSSH code but when SIGTERM is issued, 
while doing do_cleanup() it may try to cleanup the entry for user sshd process. 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1029





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-12
23:41 -------
Created an attachment (id=909)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=909&action=view)
Patch for Protocol 2 support

The patch (id=897) works for Protocol 1 but my environment strictly adheres to
Protocol 2. I simply added the protocol 2 support and it is working fine. Let
me know if the patch has any problems. With this Patch, the problem gets solved
in HP-UX.

Also when parent process exits from the loop and while doing cleanup the
SIGCHLD handler is set to do its default for server_loop() but not in
server_loop2(). Is there any specific reason? Is such a thing necessary for
SIGTERM?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1029


t8m at centrum.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t8m at centrum.cz






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.