openssh bugs - May 2005 - [Bug 1030] sshd writes twice to wtmp when "UseLogin" is yes

http://bugzilla.mindrot.org/show_bug.cgi?id=1030

           Summary: sshd writes twice to wtmp when "UseLogin" is yes
           Product: Portable OpenSSH
           Version: 4.0p1
          Platform: HPPA
        OS/Version: HP-UX
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: selvesteen at gmail.com


When "UseLogin" is set to yes, last command shows two entries for a
single user.

example: 

last -5
michael  pts/0        Wed May  4 21:32   still logged in
michael  pts/0        Wed May  4 21:32   still logged in
michael  pts/0        Wed May  4 21:22 - 21:22  (00:00)
root     pts/tb       Wed May  4 21:21   still logged in
root     pts/ta       Wed May  4 21:18   still logged in



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1030





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-05
15:54 -------
Created an attachment (id=896)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=896&action=view)
Patch for one wtmp entry if uselogin is enabled

This happens because login on invocation writes its own entry in wtmp files. To
avoid I made OpenSSH code not to write in the wtmp file if uselogin is enabled.
I like to hear comments on the approach for the attached patch. This solves the
problem in my system and Im not sure about any side effects? Also Im not sure
why the function login_utmp_only() is doing entry in wtmp?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1030


senthilkumar_sen at hotpop.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |senthilkumar_sen at hotpop.com






------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1030





------- Additional Comments From dtucker at zip.com.au  2005-05-05 20:06 -------
(In reply to comment #1)
> I like to hear comments on the approach for the attached patch. This solves
> the problem in my system and Im not sure about any side effects?
Well it will change the behaviour on other platforms.  Not sure if that will
break anything else or not.  Perhaps it ought to be enabled only on HP-UX?
>Also Im not sure why the function login_utmp_only() is doing entry in wtmp?
Not sure.  I looked in the CVS logs.  It's been that way for a long time (at
least since 2001).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1030


senthilkumar_sen at hotpop.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #896 is|0                           |1
           obsolete|                            |




------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-11
22:10 -------
Created an attachment (id=908)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=908&action=view)
Optimized patch for HP-UX

The patch is optimized and tested. I feel this duplicate entry problem occurs
only in HP-UX and not sure in other platforms which have LOGIN_NEEDS_UTMPX
defined in config.h of OpenSSH.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.