search for: server_loop

...h-2.9p2 implementation on RedHat 7.0 Linux as ssh server. For the client to exit, I expected ssh client to send SSH_CMSG_EOF to the server and the server respond with SSH_CMSG_EXITSTATUS and finally close the connection when the client sends SSH_CMSG_EXIT_CONFIRMATION. This will effectively end the server_loop in the server. This would close the connection in a cleaner way. Although the RFC has stated that either side may send SSH_MSG_DISCONNECT, for immediate disconnect, I am surprised that this is the normal exit method used in putty implementation. I fear that any addition of code after server...

...p_only(pid, s->tty, s->pw->pw_name, + get_remote_name_or_ip(utmp_len, options.reverse_mapping_check), + (struct sockaddr *)&from); +} +#endif + /* * This is called to fork and execute a command when we have no tty. This * will call do_child from the child, and server_loop from the parent after @@ -621,34 +649,6 @@ /* server_loop _has_ closed ptyfd and fdout. */ } } - -#ifdef LOGIN_NEEDS_UTMPX -void -do_pre_login(Session *s) -{ - socklen_t fromlen; - struct sockaddr_storage from; - pid_t pid = getpid(); - - /* -...

...e authctxt all the way down to channel_connect_to(). As a side effect, it's possible to get rid of the global variable x_authctxt (which seems to be sort of a hack), because it's easy to provide the authctxt information in all places where auth_get_user() is currently called. In addition, server_loop() would be changed to accept a struct passwd * and build a fake authctxt for it, to be compatible with the v2 code path. Thoughts? -- Florian Weimer Florian.Weimer at RUS.Uni-Stuttgart.DE University of Stuttgart http://cert.uni-stuttgart.de/ RUS-CERT...

https://bugzilla.mindrot.org/show_bug.cgi?id=1750 Summary: Sftp hangs if stderr is used. Product: Portable OpenSSH Version: 5.4p1 Platform: Other OS/Version: All Status: NEW Severity: major Priority: P2 Component: sshd AssignedTo: unassigned-bugs at mindrot.org ReportedBy: jchadima at

...nments. Here is a patch. 2001-09-28 Paul Eggert <eggert at twinsun.com> * authfile.c (key_perm_ok): Work even if system integer types are 'long', not 'int'. * entropy.c (prng_check_seedfile, prng_write_seedfile, prng_read_seedfile): Likewise. * serverloop.c (server_loop, server_loop2): Likewise. * session.c (session_dump, session_by_pid, session_exit_message, session_close_by_pid, session_have_children, session_close_by_channel): Likewise. * ssh-agent.c, sshd.c (main): Likewise. * sshpty.c (pty_setowner): Likewise. * uidswap.c: (temporarily...

Yes, this is a patch against an older version of OpenSSH with other stuff anyways, BUT, it's so TRIVIAL(*), that you can see how it would apply to newer versions (which I've not tried). Here's the gist: server_loop2() has a race condition with respect to reception of SIGCHLD and checking/setting child_terminated. This patch does two things: wait_until_can_do_something() adds a 1 second timeout to select() IF AND ONLY IF (!channel_still_open) AND, server_loop2() breaks out of its loop when there are no session...

When connecting with v1, the server logs a message when I exit my login shell: Closing connection to 130.207.167.32 However, when connecting with v2, it only ever logs: Connection closed by remote host. Tracing through the code, it appears that instead of breaking in serverloop.c:server_loop2() at: if (had_channel && !channel_still_open()) { debug("!channel_still_open."); break; } and returning to sshd.c:main() and logging the nice message, it continues to process_input(), gets a len==0 from the read(), and does: verbose("Connection closed...

Using the latest snapshot, I'm still getting periodic ssh sessions hanging after they've completed. It used to be very common, but the prior fixes reduced the frequency to about one hung per day (out of thousands). These don't timeout at any point, they'll hang around for days if not killed manually (blocking the scripts from continuing). The commands ssh is hanging on are nothing

...e hung-out-to-dry process): # pstack 3296 3296: /usr/local/sbin/sshd -f /etc/sshd_config ef5b7488 poll (efffd160, 2, 64) ef5cd064 select (efffd170, ef6266cc, 11e8d0, ef6266d0, 11e8d4, 11) + 280 00034560 wait_until_can_do_something (effff24c, effff248, effff244, 64, 4, 1) + 2b8 00034d74 server_loop (fb000, 0, 104000, fb000, 104000, effff240) + 20c 00036c7c do_exec_pty (10bbcc, 11, 36634, fb400, 8a, 0) + 260 00036704 do_authenticated1 (0, 36400, fac00, 106800, ef623700, 36014) + 60c 00036074 do_authenticated (110fa8, efffefbc, d0710, 400, efffefc8, 0) + 80 0002d720 do_authentication (effff...

...? Index: serverloop.c =================================================================== RCS file: /cvs/openssh/serverloop.c,v retrieving revision 1.172 diff -u -p -r1.172 serverloop.c --- serverloop.c 2 Dec 2012 22:50:55 -0000 1.172 +++ serverloop.c 4 Dec 2012 11:46:33 -0000 @@ -708,7 +708,7 @@ server_loop(pid_t pid, int fdin_arg, int &nalloc, max_time_milliseconds); if (received_sigterm) { - logit("Exiting on signal %d", received_sigterm); + logit("Exiting on signal %d", (int)received_sigterm); /* Clean up sessions, utmp, etc. */ cleanup_exit(255); }...

...is a rare behaviour we observe about once per week in a ssh intensive environment. the process hangs here: truss: 24453: poll(0xFFBEEF28, 2, -1) (sleeping...) gcore, mdb: libc.so.1`_poll+4(b, 0, 0, ffbeef38, 6fc40, ffbeef28) 0x20710(ffbef084, ffbef080, ffbef07c, ffbef078, 0, 1) server_loop2+0xd4(6a800, 0, 0, ff1e8000, 2151c, 1) do_authenticated+0x80(753b0, 6a400, f90, 1, 2151c, 6d800) main+0xbf4(2f, 6fc00, 6a800, 1ecc, 1, 6dbd0) _start+0x5c(0, 0, 0, 0, 0, 0) the corresponding c sources are: void server_loop2(Authctxt *authctxt) { [ ... ] for (;;) { process_b...

hello applied the patch described below - unfortunately we still experience rare hangs of the remote sshd. not surprising as the patch only changes a few lines in server_loop() - but not in server_loop2() which i used for non-interactive sessions. process id of hanging sshd: 26110 process is sleeping forever in poll (why does server_loop2() sleep forever?): root at XXX:~# truss -fp 26110 26110: poll(0xFFBEF268, 2, -1) (sleeping...) no child processes are aro...

http://bugzilla.mindrot.org/show_bug.cgi?id=1029 Summary: SIGTERM and cleanup of wtmp files Product: Portable OpenSSH Version: 4.0p1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: sshd AssignedTo: openssh-bugs at mindrot.org ReportedBy: senthilkumar_sen

...k into sshd. I grabbed a core from sshd when this hang happened, and gdb showed this stack trace: #0 0x281e20c4 in write () from /usr/lib/libc.so.4 #1 0x804fb18 in process_output (writeset=0xbfbfed04) at /usr/src/secure/usr.sbin/sshd/../../../crypto/openssh/serverloop.c:366 #2 0x8050029 in server_loop (pid=43486, fdin_arg=9, fdout_arg=9, fderr_arg=11) at /usr/src/secure/usr.sbin/sshd/../../../crypto/openssh/serverloop.c:563 #3 0x8053b60 in do_exec_no_pty ( command=0x80750c0 "rsync --server --sender -vlgtpr --delete . /home/ghelmer/ ", pw=0xbfbfef80, display=0x806c0a0 "moc...

...f5b0, 8d698, 0, 0, 0, 0) 0003941c ssh_dss_verify (88414, 9f5b0, 8d698, ffbeee50, 219b4, 38564) + 160 0003904c ssh_dss_sign (8d698, 0, 8d290, 400, 8d26c, 8f498) 0002a2b8 get_remote_hostname (5, 5, 28e, ffbef8c4, 4, 1) + 44 000278d0 session_open (4, ffbef94c, ffbef960, 80c00, 0, 0) + 5c 00024970 server_loop (0, 0, 0, 0, 0, 0) + 530 The relevant code is function do_pam_session() in auth-pam.c. The stack trace leads me to believe that there is a bug in Solaris pam_unix module, which is triggered if pam_open_session() is called, but PAM_TTY is not set with pam_set_item(). I worked around the problem by...

...t;parent++"); /* Parent. Close the slave side of the pseudo tty. */ close(ttyfd); + debug("parent+++"); /* * Create another descriptor of the pty master side for use as the * standard input. We could use the original descriptor, but this * simplifies code in server_loop. The descriptor is bidirectional. */ fdout = dup(ptyfd); + debug("parent++++"); if (fdout < 0) packet_disconnect("dup #1 failed: %.100s", strerror(errno)); ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching...

Hi! as I just noted, after scp the connection does not shut down properly. When I do a "scp file targethost:path", on targethost a "sshd" process is left running. I do use --with-default-path="/usr/local/openssh/bin:/usr/bin:/usr/local/bin" to assure, that the corrensponding openssh-scp is used. It also seems, that normal sessions are not always closed properly.

...key, file, realname); xfree(file); return success; } diff -ru openssh-3.1p1/serverloop.c openssh-3.1p1-mods/serverloop.c - --- openssh-3.1p1/serverloop.c Thu May 9 12:18:34 2002 +++ openssh-3.1p1-mods/serverloop.c Thu May 9 12:20:03 2002 @@ -734,12 +734,13 @@ } void - -server_loop2(Authctxt *authctxt) +server_loop2(Authctxt *authctxt, const char *realname) { fd_set *readset = NULL, *writeset = NULL; int rekeying = 0, max_fd, nalloc = 0; debug("Entering interactive session for SSH2."); + debug("VIX realname is %s ", realname...

...libexec/sftp-server\" -D_PATH_SSH_PIDDIR=\"/home/eedalf/etc\" -DHAVE_CONFIG_H -c serverloop.c serverloop.c: In function `sigchld_handler': serverloop.c:107: warning: int format, pid_t arg (arg 2) serverloop.c:107: warning: int format, pid_t arg (arg 3) serverloop.c: In function `server_loop': serverloop.c:653: warning: int format, pid_t arg (arg 2) serverloop.c:653: warning: int format, pid_t arg (arg 3) gcc -I/opt/local/zlib-1.1.2/include -Wall -I. -I. -I/home/eedalf/include -I/usr/local/include -DETCDIR=\"/home/eedalf/etc\" -D_PATH_SSH_PROGRAM=\"/home/eedalf/bin...

...D0BB45> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit Process: configd [13] Path: /usr/libexec/configd UID: 0 Thread 4c893d4 DispatchQueue 1 User stack: 14 start + 53 (in configd) [0x22d1] 14 main + 2158 (in configd) [0x2b5a] 14 server_loop + 72 (in configd) [0x3478] 14 CFRunLoopRunInMode + 97 (in CoreFoundation) [0x925c3ec1] 14 CFRunLoopRunSpecific + 452 (in CoreFoundation) [0x925c4094] 14 __CFRunLoopRun + 2079 (in CoreFoundation) [0x925c4faf] 14 mach_msg_trap + 10 (in libSystem.B.dylib) [0...