openssh bugs - May 2005 - [Bug 1032] PrintLastLog is not working with UseLogin yes

http://bugzilla.mindrot.org/show_bug.cgi?id=1032

           Summary: PrintLastLog is not working with UseLogin yes
           Product: Portable OpenSSH
           Version: 4.0p1
          Platform: All
        OS/Version: HP-UX
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: openssh-bugs at mindrot.org
        ReportedBy: senthilkumar_sen at hotpop.com
                CC: senthilkumar_sen at hotpop.com


The PrintLastLog directive is not displaying the Last Login messages when 
UseLogin is enabled.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-06
18:34 -------
Created an attachment (id=899)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=899&action=view)
Print the Login messages if UseLogin is enabled

The attached patch solves the problem in HP-UX. Im not sure about portability
problems on other platforms. Comments are welcome for the Patch. The problem is
that searching the wtmp record for Last Login is skipped when UseLogin is
enabled.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032


senthilkumar_sen at hotpop.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #899 is|0                           |1
           obsolete|                            |




------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-06
22:18 -------
Created an attachment (id=901)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=901&action=view)
Update on patch for hpux

I feel it is specific for HP-UX. Hence a update in patch.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032


senthilkumar_sen at hotpop.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #901 is|0                           |1
           obsolete|                            |




------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-10
21:54 -------
Created an attachment (id=905)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=905&action=view)
Optimized Patch for HP-UX

The current Patch is optimized and tested. Some unwanted declarations are
removed from the previous patch.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032





------- Additional Comments From djm at mindrot.org  2005-05-19 12:17 -------
(From update of attachment 905)
> #ifdef LOGIN_NEEDS_UTMPX
>-void   record_utmp_only(pid_t, const char *, const char *, const char *,
>+#ifdef __hpux
>+void   record_utmp_only(pid_t, const char *, const char *, uid_t, const
char *,
>                struct sockaddr *, socklen_t);
>+#else
>+void    record_utmp_only(pid_t, const char *, const char *, const char *,
>+               struct sockaddr *, socklen_t);
>+#endif
The prototype should never be dependant on the OS in use - that is the whole
point of the loginrec.c code. Please read the long coment at the top of
loginrec.c.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032





------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-24
22:11 -------
Ok,let me remove the OS tag and make the change as global. Will this addition of
one more argument creates problem in other platforms?

 u_long         get_last_login_time(uid_t, const char *, char *, u_int);

 #ifdef LOGIN_NEEDS_UTMPX
-void   record_utmp_only(pid_t, const char *, const char *, const char *,
+void   record_utmp_only(pid_t, const char *, const char *, uid_t, const char *,
                struct sockaddr *, socklen_t);
 #endif





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032





------- Additional Comments From djm at mindrot.org  2005-05-24 22:39 -------
Yes, that approach is fine - it is better to pass arguments that are unused on
some systems than make the list of arguments system dependant.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=1032


senthilkumar_sen at hotpop.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #905 is|0                           |1
           obsolete|                            |




------- Additional Comments From senthilkumar_sen at hotpop.com  2005-05-25
17:15 -------
Created an attachment (id=921)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=921&action=view)
Patch with removed OS dependent prototypes

The patch is modified based on Damien's feedback. Let me know the comments.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.