Goldwyn Rodrigues
2013-May-20 15:06 UTC
[Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
While removing a non-empty directory, the kernel dumps a message: (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 Suppress the error message from being printed in the dmesg so users don't panic. Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> --- diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 04ee1b5..33c7b91 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -947,7 +947,7 @@ leave: ocfs2_free_dir_lookup_result(&orphan_insert); ocfs2_free_dir_lookup_result(&lookup); - if (status) + if (status && (status != -ENOTEMPTY)) mlog_errno(status); return status;
Sunil Mushran
2013-May-22 22:53 UTC
[Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
Acked-by: Sunil Mushran <sunil.mushran at gmail.com> On Mon, May 20, 2013 at 8:06 AM, Goldwyn Rodrigues <rgoldwyn at gmail.com>wrote:> While removing a non-empty directory, the kernel dumps a message: > (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 > > Suppress the error message from being printed in the dmesg so users > don't panic. > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> > > --- > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 04ee1b5..33c7b91 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2/namei.c > @@ -947,7 +947,7 @@ leave: > ocfs2_free_dir_lookup_result(&orphan_insert); > ocfs2_free_dir_lookup_result(&lookup); > > - if (status) > + if (status && (status != -ENOTEMPTY)) > mlog_errno(status); > > return status; > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20130522/23383a46/attachment.html
xiaowei.hu
2013-May-24 06:20 UTC
[Ocfs2-devel] [PATCH] Remove unecessary ERROR when removing non-empty directory
Should we also add this (status != -ENOTEMPTY) in end of ocfs2_rename? It also may hit this unecessary error. Thanks, xiaowei On 05/20/2013 11:06 PM, Goldwyn Rodrigues wrote:> While removing a non-empty directory, the kernel dumps a message: > (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 > > Suppress the error message from being printed in the dmesg so users > don't panic. > > Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> > > --- > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 04ee1b5..33c7b91 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2/namei.c > @@ -947,7 +947,7 @@ leave: > ocfs2_free_dir_lookup_result(&orphan_insert); > ocfs2_free_dir_lookup_result(&lookup); > > - if (status) > + if (status && (status != -ENOTEMPTY)) > mlog_errno(status); > > return status; > > _______________________________________________ > Ocfs2-devel mailing list > Ocfs2-devel at oss.oracle.com > https://oss.oracle.com/mailman/listinfo/ocfs2-devel > >