Ocfs2 devel - Jul 2009 - Initialize count in aio_write before generic_write_checks

generic_write_checks() expects count to be initialized to the size of
the write.
Writes to files open with O_DIRECT|O_LARGEFILE write 0 bytes because
count in uninitialized.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>

diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index a5887df..5b9c8af 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -1841,6 +1841,7 @@ relock:
 		if (ret)
 			goto out_dio;
 
+		count = ocount;
 		ret = generic_write_checks(file, ppos, &count,
 					   S_ISBLK(inode->i_mode));
 		if (ret)

-- 
Goldwyn

Goldwyn Rodrigues wrote:
> generic_write_checks() expects count to be initialized to the size of
> the write.
> Writes to files open with O_DIRECT|O_LARGEFILE write 0 bytes because
> count in uninitialized.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
>   
Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>


> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index a5887df..5b9c8af 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1841,6 +1841,7 @@ relock:
>  		if (ret)
>  			goto out_dio;
>  
> +		count = ocount;
>  		ret = generic_write_checks(file, ppos, &count,
>  					   S_ISBLK(inode->i_mode));
>  		if (ret)
>
>

On Sat, Jul 11, 2009 at 10:57:27AM -0500, Goldwyn Rodrigues
wrote:
> generic_write_checks() expects count to be initialized to the size of
> the write.
> Writes to files open with O_DIRECT|O_LARGEFILE write 0 bytes because
> count in uninitialized.
> 
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de>
This is now in the fixes branch of ocfs2.git

Joel

-- 

Life's Little Instruction Book #237

	"Seek out the good in people."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127