search for: goldwyn

Remove redundant BUG_ON() Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de> --- diff --git a/fs/ocfs2/dlm/dlmast.c b/fs/ocfs2/dlm/dlmast.c index d07ddbe..81eff8e 100644 --- a/fs/ocfs2/dlm/dlmast.c +++ b/fs/ocfs2/dlm/dlmast.c @@ -103,7 +103,6 @@ static void __dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock) lock->a...

While removing a non-empty directory, the kernel dumps a message: (rmdir,21743,1):ocfs2_unlink:953 ERROR: status = -39 Suppress the error message from being printed in the dmesg so users don't panic. Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> --- diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 04ee1b5..33c7b91 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -947,7 +947,7 @@ leave: ocfs2_free_dir_lookup_result(&orphan_insert); ocfs2_free_dir_lookup_result(&lookup); - if...

generic_write_checks() expects count to be initialized to the size of the write. Writes to files open with O_DIRECT|O_LARGEFILE write 0 bytes because count in uninitialized. Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.de> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index a5887df..5b9c8af 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -1841,6 +1841,7 @@ relock: if (ret) goto out_dio; + count = ocount; ret = generic_write_checks(file, ppos, &count,...

Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> --- fs/ocfs2/stack_user.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index 286edf1..1b18193 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c @...

...nt to continue in any state, even read-only. From the code comments: /* Force a panic(). This stinks, but it's better than letting * things continue without having a proper hard readonly * here. */ Please execute fsck to get the journal back in shape. HTH, -- Goldwyn > >> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------...

...suggest removing the versioning system in the kernel altogether and let the kernel version be the guide to debug issues. However, if you think versioning is still required, please state the reason and modify the version string in the ver.* files to reflect the uptodate information. Signed-off-by: Goldwyn Rodrigues <rgoldwyn at suse.com> --- fs/ocfs2/Makefile | 1 - fs/ocfs2/super.c | 3 --- fs/ocfs2/ver.c | 43 ------------------------------------------- fs/ocfs2/ver.h | 31 ------------------------------- 4 files changed, 78 deletions(-) delete mode 100644 fs/ocfs2/ver.c delete m...

Add man/mkfs.btrfs.8.in Kept the name with the name in, so that further processing such as BUILD_DATE BUILD_VERSION etc. could be included later. All man pages included in the man directory to avoid file cluttering. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de> --- man/mkfs.btrfs.8.in | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 63 insertions(+), 0 deletions(-) create mode 100644 man/mkfs.btrfs.8.in diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in new file mode 100644 index 000000...

...AP_SYNC supported" checks into a > > helper so that the filesystem code just doesn't have to care about > > the details of checking for DAX+MAP_SYNC support.... > > o.k. Will add one common helper function for both ext4 & xfs filesystems. Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte at angband.pl/ We might want to coordinate. Meow! -- ??????? ??????? Did ya know that typing "test -j8" instead of "ctest -j8" ??????? will make your testsuite pass much fa...

...AP_SYNC supported" checks into a > > helper so that the filesystem code just doesn't have to care about > > the details of checking for DAX+MAP_SYNC support.... > > o.k. Will add one common helper function for both ext4 & xfs filesystems. Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte at angband.pl/ We might want to coordinate. Meow! -- ??????? ??????? Did ya know that typing "test -j8" instead of "ctest -j8" ??????? will make your testsuite pass much fa...

Add man/btrfsctl.8.in Signed-off-by: Goldwyn Rodrigues <rgoldwyn@gmail.com> --- man/btrfsctl.8.in | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 man/btrfsctl.8.in diff --git a/man/btrfsctl.8.in b/man/btrfsctl.8.in new file mode 100644 index 0000000..e11f46a -...

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@gmail.com> --- man/Makefile | 27 +++++++++++++++++++++++++++ man/btrfsck.8.in | 17 +++++++++++++++++ 2 files changed, 44 insertions(+), 0 deletions(-) create mode 100644 man/Makefile create mode 100644 man/btrfsck.8.in diff --git a/man/Makefile b/man/Makefile...

The following has been done as a part of cleanup - o Eliminated bin_search() by replacing with btrfs_bin_search() o Eliminated unused return value in fixup_low_keys() o Eliminated additional variable (sret) in setup_nodes_for_search() Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de> --- ctree.c | 71 ++++++++++++++++++---------------------------------------------- 1 file changed, 20 insertions(+), 51 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 9ac1715..69f71e8 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@...

...ted aborted journal ________________________________ zhangguanghui Message: 8 Date: Fri, 28 Aug 2015 16:45:44 -0700 From: Mark Fasheh <mfasheh at suse.de> Subject: Re: [Ocfs2-devel] [patch 04/28] ocfs2: add errors=continue To: akpm at linux-foundation.org Cc: ocfs2-devel at oss.oracle.com, rgoldwyn at suse.com Message-ID: <20150828234544.GN1145 at wotan.suse.de> Content-Type: text/plain; charset=us-ascii On Wed, Aug 26, 2015 at 03:11:29PM -0700, Andrew Morton wrote: > From: Goldwyn Rodrigues <rgoldwyn at suse.de> > Subject: ocfs2: add errors=continue > > OCFS2 is ofte...

...ted aborted journal ________________________________ zhangguanghui Message: 8 Date: Fri, 28 Aug 2015 16:45:44 -0700 From: Mark Fasheh <mfasheh at suse.de> Subject: Re: [Ocfs2-devel] [patch 04/28] ocfs2: add errors=continue To: akpm at linux-foundation.org Cc: ocfs2-devel at oss.oracle.com, rgoldwyn at suse.com Message-ID: <20150828234544.GN1145 at wotan.suse.de> Content-Type: text/plain; charset=us-ascii On Wed, Aug 26, 2015 at 03:11:29PM -0700, Andrew Morton wrote: > From: Goldwyn Rodrigues <rgoldwyn at suse.de> > Subject: ocfs2: add errors=continue > > OCFS2 is ofte...

====================================================== "I read part of it all the way through." Samuel Goldwyn ====================================================== Release Announcements --------------------- This is the latest stable release of Samba 4.4. This release fixes some regressions introduced by the last security fixes. Please see bug https://bugzilla.samba.org/show_bug.cgi?id=11849 for a lis...

====================================================== "I read part of it all the way through." Samuel Goldwyn ====================================================== Release Announcements --------------------- This is the latest stable release of Samba 4.4. This release fixes some regressions introduced by the last security fixes. Please see bug https://bugzilla.samba.org/show_bug.cgi?id=11849 for a lis...

Hi, we ran into a BUG() in ocfs2_get_clusters_nocache: [Fri Oct 18 10:52:28 2013] ------------[ cut here ]------------ [Fri Oct 18 10:52:28 2013] Kernel BUG at ffffffffa028ad5a [verbose debug info unavailable] [Fri Oct 18 10:52:28 2013] invalid opcode: 0000 [#1] SMP [Fri Oct 18 10:52:28 2013] Modules linked in: vhost_net vhost macvtap macvlan drbd ip6table_filter ip6_tables iptable_filter

...nticate user administrator with challenge/response Does someone have any idea of could go wrong? When I use squid and samba on different machines i usually join the squid machine to the domain using a net join, is this necesary when the pdc and squid are on the same machine? Victor Medina Samuel Goldwyn - "I don't think anyone should write their autobiography until after they're dead."

...into a > > > helper so that the filesystem code just doesn't have to care about > > > the details of checking for DAX+MAP_SYNC support.... > > > > o.k. Will add one common helper function for both ext4 & xfs filesystems. > > Note this pending patch for Goldwyn Rodrigues' patchset for btrfs: > > https://lore.kernel.org/linux-btrfs/20190328102418.5466-1-kilobyte at angband.pl/ > > We might want to coordinate. Sure. Good to know. Thanks for the pointer. Will have a look. Best regards, Pankaj > > > Meow! > -- > ???????...

...#39;' branch in git works for you. I''ll probably release tomorrow, or maybe early on Thursday if I don''t hear of any show-stoppers. -- I don''t want any yes-men around me. I want everybody to tell me the truth even if it costs them their jobs. -- Samuel Goldwyn --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com