2015-06-08 13:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>:> On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote: > > -ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Liebert" > > > > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power Co., Ltd" > > I'm guessing this would require changes in NUT, so I should mention I > don't like that change. Maybe: > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power" > would be better? The names are supposed to be human readable. >though I see your rationales behind that comments, this is not NUT-only, but also tied to usb.ids and devices USB strings and maintenance / cross linking info: https://usb-ids.gowdy.us/read/UD/06da Note that such change would not make it more human readable, it's just a truncation ;) So I'm not in favor of changing this. cheers, Arno -- Eaton Data Center Automation - Opensource Leader NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.fr -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/1f241ec0/attachment-0001.html>
On Mon, 2015-06-08 at 13:21 +0200, Arnaud Quette wrote:> > > 2015-06-08 13:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote: > > > -ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Liebert" > > > > > > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power > > Co., Ltd" > > > > I'm guessing this would require changes in NUT, so I should mention > > I > > don't like that change. Maybe: > > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power" > > would be better? The names are supposed to be human readable. > though I see your rationales behind that comments, this is not NUT > -only, but also tied to usb.ids and devices USB strings and > maintenance / cross linking info: > https://usb-ids.gowdy.us/read/UD/06da > > Note that such change would not make it more human readable, it's > just a truncation ;) > So I'm not in favor of changing this.Actually, shouldn't it say "Eaton" now: http://www.eaton.com/Eaton/OurCompany/NewsEvents/NewsReleases/CT_141334 ? It's also named simply "Phoenixtec" in the NUT docs: http://www.networkupstools.org/protocols/sola.html Anyway.
2015-06-08 14:07 GMT+02:00 Bastien Nocera <hadess at hadess.net>:> On Mon, 2015-06-08 at 13:21 +0200, Arnaud Quette wrote: > > > > > > 2015-06-08 13:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>: > > > On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote: > > > > -ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Liebert" > > > > > > > > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power > > > Co., Ltd" > > > > > > I'm guessing this would require changes in NUT, so I should mention > > > I > > > don't like that change. Maybe: > > > +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec Power" > > > would be better? The names are supposed to be human readable. > > though I see your rationales behind that comments, this is not NUT > > -only, but also tied to usb.ids and devices USB strings and > > maintenance / cross linking info: > > https://usb-ids.gowdy.us/read/UD/06da > > > > Note that such change would not make it more human readable, it's > > just a truncation ;) > > So I'm not in favor of changing this. > > Actually, shouldn't it say "Eaton" now: > http://www.eaton.com/Eaton/OurCompany/NewsEvents/NewsReleases/CT_141334 > ? >well, yes and no ("une r?ponse de Breton" as we say in French ;)) same as for MGE | Powerware | Best | Deltec | Sola | ...(very long list of acquisition). The difference here, for the sake of completion, is that PTec (short name) or actually Centralion (same company, but different division) is manufacturing OEM products, that are then just rebranded by Liebert, Mustek and numerous other brands, depending on the considered timeframe.> It's also named simply "Phoenixtec" in the NUT docs: > http://www.networkupstools.org/protocols/sola.html >sure, there is still some du cleanup there ;) Anyway.>so, works for you as is?! thanks for your understanding. cheers, Arno -- Eaton Data Center Automation - Opensource Leader NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org Debian Developer - http://www.debian.org Free Software Developer - http://arnaud.quette.fr -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/17b033c6/attachment.html>