Nut upsdev - Jun 2015 - UPower: 95-upower-hid.rules update

Salut Bastien

2015-06-04 13:04 GMT+02:00 Bastien Nocera <hadess at hadess.net>:
> On Sat, 2015-05-30 at 18:51 +0200, Arnaud Quette wrote:
> >
> >
> > 2015-05-29 14:09 GMT+02:00 Bastien Nocera <hadess at
hadess.net>:
> > > On Fri, 2015-05-29 at 13:59 +0200, Arnaud Quette wrote:
> > > > Hi Richard and the list,
> > > >
> > > > you'll find attached a patch for 95-upower-hid.rules,
which adds:
> > > > - the "usbmisc" filtering, as added in your repo,
> > > > - more comments, including one that points at your UPower
repo,
> > > > - 3 new manufacturers (Minibox, iDowell and Powerware)
> > > > - a bunch of new devices (7 HP,  1 APC, 1 TrippLite, 2
PowerCOM
> > > and 2
> > > > Liebert)
> > >
> > > Could you please split those changes into 3 separate patches?
> >
> > since you already have the "usbmisc", I can possibly check
to split
> > in 2 commits (1 for the comments, and 1 for the content update).
> > would that suits you that way?
>
> Sure.
>
please find attached the first patch, addressing the added devices.
I'll send the comments update patch once you ack'ed my previous message.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/52de27a8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-UPower-HID-rules-supported-devices-list.patch
Type: application/octet-stream
Size: 6208 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/52de27a8/attachment.obj>

On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote:
> -ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Liebert"
> 
> +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec
Power Co., Ltd"
I'm guessing this would require changes in NUT, so I should mention I
don't like that change. Maybe:
+ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec
Power"
would be better? The names are supposed to be human readable.

Cheers

2015-06-08 13:09 GMT+02:00 Bastien Nocera <hadess at hadess.net>:
> On Mon, 2015-06-08 at 10:13 +0200, Arnaud Quette wrote:
> > -ATTRS{idVendor}=="06da",
ENV{UPOWER_VENDOR}="Liebert"
> >
> > +ATTRS{idVendor}=="06da",
ENV{UPOWER_VENDOR}="Phoenixtec Power Co., Ltd"
>
> I'm guessing this would require changes in NUT, so I should mention I
> don't like that change. Maybe:
> +ATTRS{idVendor}=="06da", ENV{UPOWER_VENDOR}="Phoenixtec
Power"
> would be better? The names are supposed to be human readable.
>
though I see your rationales behind that comments, this is not NUT-only,
but also tied to usb.ids and devices USB strings and maintenance / cross
linking info:
https://usb-ids.gowdy.us/read/UD/06da

Note that such change would not make it more human readable, it's just a
truncation ;)
So I'm not in favor of changing this.

cheers,
Arno
-- 
Eaton Data Center Automation - Opensource Leader
NUT (Network UPS Tools) Project Leader - http://www.networkupstools.org
Debian Developer - http://www.debian.org
Free Software Developer - http://arnaud.quette.fr
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20150608/1f241ec0/attachment-0001.html>

On 8 June 2015 at 09:13, Arnaud Quette <arnaud.quette at gmail.com>
wrote:
> please find attached the first patch, addressing the added devices.
I've pushed this, thanks.

Richard.