Nouveau - Aug 2019 - [Intel-gfx] [PATCH v6 08/17] drm/ttm: use gem vma_node

Hi,
> > Changing the order doesn't look hard.  Patch attached (untested,
have no
> > test hardware).  But maybe I missed some detail ...
> 
> I came up with something very similar by splitting up nouveau_bo_new()
> into allocation and initialization steps, so that when necessary the GEM
> object can be initialized in between. I think that's slightly more
> flexible and easier to understand than a boolean flag.
Yes, that should work too.

Acked-by: Gerd Hoffmann <kraxel at redhat.com>

cheers,
  Gerd

On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann <kraxel at redhat.com>
wrote:
>
>   Hi,
>
> > > Changing the order doesn't look hard.  Patch attached
(untested, have no
> > > test hardware).  But maybe I missed some detail ...
> >
> > I came up with something very similar by splitting up nouveau_bo_new()
> > into allocation and initialization steps, so that when necessary the
GEM
> > object can be initialized in between. I think that's slightly more
> > flexible and easier to understand than a boolean flag.
>
> Yes, that should work too.
>
> Acked-by: Gerd Hoffmann <kraxel at redhat.com>
Acked-by: Ben Skeggs <bskeggs at redhat.com>
>
> cheers,
>   Gerd
>
> _______________________________________________
> Nouveau mailing list
> Nouveau at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

On Wed, Aug 21, 2019 at 04:33:58PM +1000, Ben Skeggs
wrote:
> On Wed, 14 Aug 2019 at 20:14, Gerd Hoffmann <kraxel at redhat.com>
wrote:
> >
> >   Hi,
> >
> > > > Changing the order doesn't look hard.  Patch attached
(untested, have no
> > > > test hardware).  But maybe I missed some detail ...
> > >
> > > I came up with something very similar by splitting up
nouveau_bo_new()
> > > into allocation and initialization steps, so that when necessary
the GEM
> > > object can be initialized in between. I think that's slightly
more
> > > flexible and easier to understand than a boolean flag.
> >
> > Yes, that should work too.
> >
> > Acked-by: Gerd Hoffmann <kraxel at redhat.com>
> Acked-by: Ben Skeggs <bskeggs at redhat.com>
Thanks guys, applied to drm-misc-next.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190821/be420548/attachment.sig>