Logcheck devel - May 2004 - Bug#251364: logcheck: preinst has bashism, fails with dash and LANG != C

Package: logcheck
Version: 1.2.20a
Severity: serious
Tags: patch

On a system where sh points to dash and LANG=es_ES, I get this:

# apt-get -y --reinstall install logcheck
Leyendo lista de paquetes... 0%
Leyendo lista de paquetes... 0%
Leyendo lista de paquetes... 23%
Leyendo lista de paquetes... Hecho
Creando ?rbol de dependencias... 0%
Creando ?rbol de dependencias... 0%
Creando ?rbol de dependencias... 50%
Creando ?rbol de dependencias... 50%
Creando ?rbol de dependencias... Hecho
0 actualizados, 0 se instalar?n, 1 reinstalados, 0 para eliminar y 1 no
actualizados.
Se necesita descargar 0B/34,0kB de archivos.
Se utilizar?n 0B de espacio de disco adicional despu?s de desempaquetar.
Preconfiguring packages ...
(Leyendo la base de datos ...
45379 ficheros y directorios instalados actualmente.)
Preparando para reemplazar logcheck 1.2.20a (usando
.../logcheck_1.2.20a_all.deb) ...
Desempaquetando el reemplazo de logcheck ...
Eliminando usuario logcheck...
Configurando logcheck (1.2.20a) ...
hecho.
chown: `logcheck:logcheck': usuario inv?lido
chown: `logcheck:logcheck': usuario inv?lido
chgrp: nombre de grupo inv?lido `logcheck'
chown: `logcheck': usuario inv?lido

It seems &>/dev/null in preinst is not allowed by dash.

Patch follows:

--- preinst.orig	2004-05-28 10:10:11.000000000 +0200
+++ preinst	2004-05-28 10:10:24.000000000 +0200
@@ -5,7 +5,7 @@

 set -e

-deluser logcheck &>/dev/null || true
+deluser logcheck > /dev/null 2>&1 || true
 adduser --quiet --system --no-create-home --group --home /var/lib/logcheck \
 	logcheck || true
 adduser --quiet logcheck adm ||true


Thanks.

On Fri, 28 May 2004, Santiago Vila wrote:
> Package: logcheck
> Version: 1.2.20a
> Severity: serious
> Tags: patch
> 
> On a system where sh points to dash and LANG=es_ES, I get this:
> 
> # apt-get -y --reinstall install logcheck
> Leyendo lista de paquetes... 0%
> Leyendo lista de paquetes... 0%
> Leyendo lista de paquetes... 23%
> Leyendo lista de paquetes... Hecho
> Creando ?rbol de dependencias... 0%
> Creando ?rbol de dependencias... 0%
> Creando ?rbol de dependencias... 50%
> Creando ?rbol de dependencias... 50%
> Creando ?rbol de dependencias... Hecho
> 0 actualizados, 0 se instalar?n, 1 reinstalados, 0 para eliminar y 1 no
actualizados.
> Se necesita descargar 0B/34,0kB de archivos.
> Se utilizar?n 0B de espacio de disco adicional despu?s de desempaquetar.
> Preconfiguring packages ...
> (Leyendo la base de datos ...
> 45379 ficheros y directorios instalados actualmente.)
> Preparando para reemplazar logcheck 1.2.20a (usando
.../logcheck_1.2.20a_all.deb) ...
> Desempaquetando el reemplazo de logcheck ...
> Eliminando usuario logcheck...
> Configurando logcheck (1.2.20a) ...
> hecho.
> chown: `logcheck:logcheck': usuario inv?lido
> chown: `logcheck:logcheck': usuario inv?lido
> chgrp: nombre de grupo inv?lido `logcheck'
> chown: `logcheck': usuario inv?lido
> 
> It seems &>/dev/null in preinst is not allowed by dash.
> 
> Patch follows:
ok thanks, i've tested your patch on bash and it works,
commited it to latest cvs on alioth,
could you test the fix on your system:
please add to your sources.list (apt-get update && apt-get upgrade)
# logcheck testing
deb http://debian.stro.at sarge/
deb-src http://debian.stro.at sarge/

you'll get the release canditat for 1.2.21 logcheck,
thanks for your feedback in advance.
i'll hope we can release that nailed down.

a+ maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040528/ca9a2ac9/attachment.pgp

Your message dated Thu, 03 Jun 2004 06:02:03 -0400
with message-id <E1BVp2x-00024I-00 at newraff.debian.org>
and subject line Bug#251364: fixed in logcheck 1.2.21
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 28 May 2004 08:12:31
+0000
>From sanvila at unex.es Fri May 28 01:12:31 2004
Return-path: <sanvila at unex.es>
Received: from pizarro.unex.es [158.49.8.2] (postfix)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BTcTb-0000p7-00; Fri, 28 May 2004 01:12:30 -0700
Received: from localhost (almendralejo.unex.es [158.49.8.199])
	by pizarro.unex.es (Postfix/MJ-1.08) with ESMTP id 3AFBAA1D1B
	for <submit at bugs.debian.org>; Fri, 28 May 2004 10:12:26 +0200 (CEST)
Received: from pizarro.unex.es ([158.49.8.2])
	by localhost (emilio [158.49.17.20]) (amavisd-new, port 10024)
	with ESMTP id 13693-06 for <submit at bugs.debian.org>;
	Fri, 28 May 2004 10:13:28 +0200 (CEST)
Received: from guadiana.unex.es (guadiana.unex.es [158.49.17.23])
	by pizarro.unex.es (Postfix/MJ-1.08) with ESMTP id 2AD78A1C78
	for <submit at bugs.debian.org>; Fri, 28 May 2004 10:12:26 +0200 (CEST)
Received: from guadiana.unex.es
	([158.49.17.23] helo=localhost ident=sanvila)
	by guadiana.unex.es with esmtp (Exim 3.35 #1 (Debian))
	id 1BTcTZ-0002tU-00
	for <submit at bugs.debian.org>; Fri, 28 May 2004 10:12:26 +0200
Date: Fri, 28 May 2004 10:13:34 +0200 (CEST)
From: Santiago Vila <sanvila at unex.es>
To: submit at bugs.debian.org
Subject: logcheck: preinst has bashism, fails with dash and LANG != C
Message-ID: <Pine.LNX.4.58.0405280954110.2469 at athlon.unex.es>
X-Debbugs-Cc: sanvila at unex.es
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
X-Virus-Scanned: by amavisd-new-20030616-p7 (Debian) at unex.es
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: logcheck
Version: 1.2.20a
Severity: serious
Tags: patch

On a system where sh points to dash and LANG=3Des_ES, I get this:

# apt-get -y --reinstall install logcheck
Leyendo lista de paquetes... 0%
Leyendo lista de paquetes... 0%
Leyendo lista de paquetes... 23%
Leyendo lista de paquetes... Hecho
Creando =E1rbol de dependencias... 0%
Creando =E1rbol de dependencias... 0%
Creando =E1rbol de dependencias... 50%
Creando =E1rbol de dependencias... 50%
Creando =E1rbol de dependencias... Hecho
0 actualizados, 0 se instalar=E1n, 1 reinstalados, 0 para eliminar y 1 no
actualizados.
Se necesita descargar 0B/34,0kB de archivos.
Se utilizar=E1n 0B de espacio de disco adicional despu=E9s de desempaquetar=2E
Preconfiguring packages ...
(Leyendo la base de datos ...
45379 ficheros y directorios instalados actualmente.)
Preparando para reemplazar logcheck 1.2.20a (usando
.../logcheck_1.2.20a_all.deb) ...
Desempaquetando el reemplazo de logcheck ...
Eliminando usuario logcheck...
Configurando logcheck (1.2.20a) ...
hecho.
chown: `logcheck:logcheck': usuario inv=E1lido
chown: `logcheck:logcheck': usuario inv=E1lido
chgrp: nombre de grupo inv=E1lido `logcheck'
chown: `logcheck': usuario inv=E1lido

It seems &>/dev/null in preinst is not allowed by dash.

Patch follows:

--- preinst.orig=092004-05-28 10:10:11.000000000 +0200
+++ preinst=092004-05-28 10:10:24.000000000 +0200
@@ -5,7 +5,7 @@

 set -e

-deluser logcheck &>/dev/null || true
+deluser logcheck > /dev/null 2>&1 || true
 adduser --quiet --system --no-create-home --group --home /var/lib/logcheck \
 =09logcheck || true
 adduser --quiet logcheck adm ||true


Thanks.

---------------------------------------
Received: (at 251364-close) by bugs.debian.org; 3 Jun 2004 10:08:33
+0000
>From katie at ftp-master.debian.org Thu Jun 03 03:08:33 2004
Return-path: <katie at ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BVp9F-0005Oa-00; Thu, 03 Jun 2004 03:08:33 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BVp2x-00024I-00; Thu, 03 Jun 2004 06:02:03 -0400
From: Todd Troxell <ttroxell at debian.org>
To: 251364-close at bugs.debian.org
X-Katie: $Revision: 1.49 $
Subject: Bug#251364: fixed in logcheck 1.2.21
Message-Id: <E1BVp2x-00024I-00 at newraff.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Thu, 03 Jun 2004 06:02:03 -0400
Delivered-To: 251364-close at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 16

Source: logcheck
Source-Version: 1.2.21

We believe that the bug you reported is fixed in the latest version of
logcheck, which is due to be installed in the Debian FTP archive:

logcheck-database_1.2.21_all.deb
  to pool/main/l/logcheck/logcheck-database_1.2.21_all.deb
logcheck_1.2.21.dsc
  to pool/main/l/logcheck/logcheck_1.2.21.dsc
logcheck_1.2.21.tar.gz
  to pool/main/l/logcheck/logcheck_1.2.21.tar.gz
logcheck_1.2.21_all.deb
  to pool/main/l/logcheck/logcheck_1.2.21_all.deb
logtail_1.2.21_all.deb
  to pool/main/l/logcheck/logtail_1.2.21_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 251364 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Todd Troxell <ttroxell at debian.org> (supplier of updated logcheck
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thursday, 03 Jun 2004 05:49:47 -0500
Source: logcheck
Binary: logcheck logtail logcheck-database
Architecture: source all
Version: 1.2.21
Distribution: unstable
Urgency: low
Maintainer: Debian logcheck Team <logcheck-devel at
lists.alioth.debian.org>
Changed-By: Todd Troxell <ttroxell at debian.org>
Description: 
 logcheck   - Mails anomalies in the system logfiles to the administrator
 logcheck-database - A database of system log rules for the use of log checkers
 logtail    - Print log file lines that have not been read
Closes: 174173 182992 186849 192192 198767 213709 222240 226937 248409 248816
249074 249181 249324 250373 250374 251364 251463 252173
Changes: 
 logcheck (1.2.21) unstable; urgency=low
 .
   maks:
   * Better description of logtail package.
   * Recommend use of an offsite email address in main conf.
   * Added and updated bind, cracklib, innd, kernel, logcheck, nntpcache,
     Login.app, proftp, postfix, pump, sendmail rulefiles.
     (Closes: #248816, #213709, #198767, #248409, #249074, #250374, #250373,
      #249181)
   * Added -v switch (outputs logcheck version).
   * Harden permissions regarding world.
   * Added and updated arpwatch, bind, gconf, gdm, kernel, openvpn, postfix,
     rpc.statd and spamd rules.  thanks to Peter Palfrader <weasel at
debian.org>.
   * New Config option for subject tags [logcheck].
   * Lower all debconf messages priority.
   * Added and updated oidentd rules. (Closes: #186849)
     thanks to Tobias Wolter <towo+bugs at ydal.de>
   * Ignore normal use of su and sudo. (Closes: #182992, #192192)
   * Remove empty file innd.
   * Add switches to logtails default arguments.
   * Added cvs-build, cvs-clean debian/rules - stolen from apt.
   * Denote /etc/logcheck/logcheck.logfile as CFG in manpage and logcheck.
   * Move logtail.8 from debian to doc dir.
   * Added Japanese translation. thanks to Hideki Yamane (Closes: #251463)
   * Added French translation. thanks to R?mi Pannequin (Closes: #252173)
   * Fix bashishm in preinst and postinst. (Closes: #251364)
   todd:
   * Add debconf to logcheck Depends:
   * Check the return values of all commands that write to disk.
     (Closes: #174173)
   * Add NEWS.Debian to logcheck.docs (Followup to #247360)
   eevans:
   * Made addition of logcheck user and permissions/ownership changes a
     conditional of an upgrade from a version less than 1.2.19.
     (Closes: #249324)
   * Added a note to README.Debian on how to manually change the cronjob
     interval. (Closes: #222240, #226937)
   alfie:
   * src/logcheck: test also for readability for the header.txt and footer.txt.
   * debian/changelog: stripped all trailing whitespace from the file.
   * debian/*templates: Some small consistency and formating updates. Updated
     the debian/po/*.po files too.
Files: 
 ca12c9c51dc70453a7fcb1859f17ccc3 670 admin optional logcheck_1.2.21.dsc
 2def0e9e4ccc428e49126c5e391e4597 72037 admin optional logcheck_1.2.21.tar.gz
 c87bba838b413e6f939edd7336e07579 36388 admin optional logcheck_1.2.21_all.deb
 806b69d2d16042c4f2060df79d73a1bd 39956 admin optional
logcheck-database_1.2.21_all.deb
 2554603f91374e07d19293a5277ab153 21170 admin optional logtail_1.2.21_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD4DBQFAvvYw4u3oQ3FHP2YRAkukAKCztbEVc4ziE6zmo4VijzQHma/yKwCYvKTP
1FzcH4V8Ag3K8hSwSnDbvw==s9Dc
-----END PGP SIGNATURE-----