Hello, I’ve noticed that XRay does not report the PID in the trace log. Could this be added for multi-process support? (Maybe as a command line argument). Thanks, Henry -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180611/f800c333/attachment.html>
Dean Michael Berris via llvm-dev
2018-Jun-12 00:31 UTC
[llvm-dev] XRay feature – pid reporting
> On 12 Jun 2018, at 07:49, Henry Zhu via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hello, > > > I’ve noticed that XRay does not report the PID in the trace log. Could this be added for multi-process support? (Maybe as a command line argument). >We can certainly add the PID in the trace header. This will be a format change which will require a version increment, but we’ve done that before so it should be doable. Do you have time to implement this feature? It will span LLVM and compiler-rt, but it should be straight-forward to do so. Let me know and I’ll get you an example patch that did this for some of the changes we’ve done recently in this regard. Keith can also help as he’s worked on updating the FDR format in the past as well. Cheers -- Dean
I would be happy to help. Could you send me the example patch? Where would I submit my patch to be reviewed? Thanks, Henry On Mon, Jun 11, 2018 at 8:31 PM, Dean Michael Berris <dean.berris at gmail.com> wrote:> > > > On 12 Jun 2018, at 07:49, Henry Zhu via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > Hello, > > > > > > I’ve noticed that XRay does not report the PID in the trace log. Could > this be added for multi-process support? (Maybe as a command line argument). > > > > We can certainly add the PID in the trace header. This will be a format > change which will require a version increment, but we’ve done that before > so it should be doable. > > Do you have time to implement this feature? It will span LLVM and > compiler-rt, but it should be straight-forward to do so. > > Let me know and I’ll get you an example patch that did this for some of > the changes we’ve done recently in this regard. Keith can also help as he’s > worked on updating the FDR format in the past as well. > > Cheers > > -- Dean > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180625/43e981b7/attachment.html>