llvm dev - Jan 2018 - [RFC] Enable Partial Inliner by default

Hello All,

This conversations seems to have fizzled out and I would like to try to
revive it. My intention is to pick up where Graham left off with enabling
partial-inlining by default.

On Sat, Dec 9, 2017 at 7:47 AM, Florian Hahn via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hi,
>
> On 13/11/2017 14:47, Evgeny Astigeevich via llvm-dev wrote:
>
>> Hi Graham,
>>
>> I created a bug report with a reproducer for the failures I’ve got:
>> https://bugs.llvm.org/show_bug.cgi?id=35288
>>
>>
> That bug should be fixed by https://reviews.llvm.org/rL320199
>
> Cheers,
> Florian
> <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>
>
Thanks for fixing this Florian. Now that this is no longer blocking, are
there other concerns over enabling PI by default?

Evgeny, did you get a chance to look into the code-size regressions on
AArch targets? What do you think about moving ahead with this?


Thanks
Sean
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180129/4cf0cd3b/attachment.html>

Hi Sean,

Thank you for reminding me.
It looks like it get lost among tons of emails and other tasks.
I’ll check if the code size issues still exist.

Thanks,
Evgeny Astigeevich

From: Sean Fertile <sd.fertile at gmail.com>
Date: Monday, 29 January 2018 at 19:52
To: Florian Hahn <Florian.Hahn at arm.com>
Cc: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>, Graham Yiu
<gyiu at ca.ibm.com>, "junbuml at codeaurora.org" <junbuml at
codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at
lists.llvm.org>, Tobias Grosser <tobias.grosser at inf.ethz.ch>, nd
<nd at arm.com>
Subject: Re: [llvm-dev] [RFC] Enable Partial Inliner by default


Hello All,

This conversations seems to have fizzled out and I would like to try to revive
it. My intention is to pick up where Graham left off with enabling
partial-inlining by default.

On Sat, Dec 9, 2017 at 7:47 AM, Florian Hahn via llvm-dev <llvm-dev at
lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Hi,

On 13/11/2017 14:47, Evgeny Astigeevich via llvm-dev wrote:
Hi Graham,

I created a bug report with a reproducer for the failures I’ve got:
https://bugs.llvm.org/show_bug.cgi?id=35288

That bug should be fixed by https://reviews.llvm.org/rL320199

Cheers,
Florian

Thanks for fixing this Florian. Now that this is no longer blocking, are there
other concerns over enabling PI by default?

Evgeny, did you get a chance to look into the code-size regressions on AArch
targets? What do you think about moving ahead with this?

Thanks
Sean
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180129/513c68bf/attachment.html>

Hi Sean,

I have looked at the code size issues and identified the root cause of them.
The biggest code size increase (from 35512 bytes to 44184 bytes, +24%) is for
MultiSource/Benchmarks/MiBench/automotive-susan
(http://www.llvm.org/viewvc/llvm-project/test-suite/trunk/MultiSource/Benchmarks/MiBench/automotive-susan/susan.c?view=markup).

Compiler options: clang  -O3 -DNDEBUG -mcpu=cortex-a57 -fomit-frame-pointer  -c
MultiSource/Benchmarks/MiBench/automotive-susan/susan.c

The problem is that the partial inliner “duplicates” huge functions. I mean
“duplicates” because a difference between the original function and the one
created by the partial inliner is very small.
For example:

define dso_local i32 @susan_edges_small…{
entry:
  %0 = bitcast i32* %r to i8*
  %mul = mul nsw i32 %y_size, %x_size
  %conv = sext i32 %mul to i64
  %mul1 = shl nsw i64 %conv, 2
  tail call void @llvm.memset.p0i8.i64(i8* align 4 %0, i8 0, i64 %mul1, i1
false)
  %cmp645 = icmp sgt i32 %y_size, 2
  br i1 %cmp645, label %for.cond3.preheader.lr.ph, label %for.end398
…
<<A lot of code: ~500 lines of IR>>
…
for.end398:                                       ; preds = %for.inc396, %entry,
%for.cond84.preheader
  ret i32 undef
}

The partial inliner creates @susan_edges_small.50_for.cond3.preheader.lr.ph
where those 500 lines of IR are put.  This results in two huge functions.

There are four such big functions in susan.c: susan_edges_small, susan_edges,
susan_thin and susan_principle.

IMHO the issue can be solved when functions are put into own sections (this mode
is off by default) and then removed by a linker. However this will raise
additional requirements how to build and to link an application which cannot be
met in all cases.

Thanks,
Evgeny Astigeevich


From: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>
Date: Monday, 29 January 2018 at 20:00
To: Sean Fertile <sd.fertile at gmail.com>, Florian Hahn <Florian.Hahn
at arm.com>
Cc: Graham Yiu <gyiu at ca.ibm.com>, "junbuml at codeaurora.org"
<junbuml at codeaurora.org>, "llvm-dev at lists.llvm.org"
<llvm-dev at lists.llvm.org>, Tobias Grosser <tobias.grosser at
inf.ethz.ch>, nd <nd at arm.com>
Subject: Re: [llvm-dev] [RFC] Enable Partial Inliner by default

Hi Sean,

Thank you for reminding me.
It looks like it get lost among tons of emails and other tasks.
I’ll check if the code size issues still exist.

Thanks,
Evgeny Astigeevich

From: Sean Fertile <sd.fertile at gmail.com>
Date: Monday, 29 January 2018 at 19:52
To: Florian Hahn <Florian.Hahn at arm.com>
Cc: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>, Graham Yiu
<gyiu at ca.ibm.com>, "junbuml at codeaurora.org" <junbuml at
codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at
lists.llvm.org>, Tobias Grosser <tobias.grosser at inf.ethz.ch>, nd
<nd at arm.com>
Subject: Re: [llvm-dev] [RFC] Enable Partial Inliner by default


Hello All,

This conversations seems to have fizzled out and I would like to try to revive
it. My intention is to pick up where Graham left off with enabling
partial-inlining by default.

On Sat, Dec 9, 2017 at 7:47 AM, Florian Hahn via llvm-dev <llvm-dev at
lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Hi,

On 13/11/2017 14:47, Evgeny Astigeevich via llvm-dev wrote:
Hi Graham,

I created a bug report with a reproducer for the failures I’ve got:
https://bugs.llvm.org/show_bug.cgi?id=35288

That bug should be fixed by https://reviews.llvm.org/rL320199

Cheers,
Florian

Thanks for fixing this Florian. Now that this is no longer blocking, are there
other concerns over enabling PI by default?

Evgeny, did you get a chance to look into the code-size regressions on AArch
targets? What do you think about moving ahead with this?


Thanks
Sean
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180502/e4386350/attachment-0001.html>