search for: gyiu

...video/presentation on how PGO information is represented in LLVM and what information is passed via the IR? I'm finding some difficulty in getting the big picture via the code. Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Teresa Johnson <tejohnson at google.com> To: Easwaran Raman <eraman at google.com> Cc: Graham Yiu <gyiu at ca.ibm.com>, llvm-dev <llvm-dev at lists.llvm.org> Date: 10/03/2017 05:00 PM Subject: Re: [llvm-dev] PGO information at LTO/thinLTO l...

...o handle ? Going through the code, it looks like the only requirement is for the header to dominate all the BB in the region ; On Sat, Aug 26, 2017 at 9:52 AM, Xinliang David Li via llvm-dev < llvm-dev at lists.llvm.org> wrote: > > > On Thu, Aug 24, 2017 at 12:47 PM, Graham Yiu <gyiu at ca.ibm.com> wrote: > >> Hi David, >> >> The only reason I can see to use the 'pattern matching' part as a >> fall-back is in case we cannot inline the (what I'm assuming would be) a >> much bigger hot-path-only cloned function for whatever reason....

Hi Graham, Thank you for offering help. I am trying to create a reproducer. The problem is that the crashes happen whilst LTO is used. One thing I am sure about IR is broken at compile time. Thanks, Evgeny From: Graham Yiu <gyiu at ca.ibm.com> Date: Friday, 10 November 2017 at 16:09 To: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com> Cc: "junbuml at codeaurora.org" <junbuml at codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, nd <nd at arm.com>, To...

...ck. At a high level, I have two questions: 1. What is the main obstacle that prevent the pass from being enabled by default? 2. Would it make sense to give some bonus in the cost model when we detect the possibility of spilling CSRs in the entry block? Thanks, Jun From: Graham Yiu [mailto:gyiu at ca.ibm.com] Sent: Tuesday, October 3, 2017 11:08 AM To: junbuml at codeaurora.org Cc: llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] General question about enabling partial inlining Hi Jun, We're actually looking at enhancing the partial inlining pass right now (see <http://list...

On Tue, Oct 3, 2017 at 1:46 PM, Teresa Johnson via llvm-dev < llvm-dev at lists.llvm.org> wrote: > > > On Tue, Oct 3, 2017 at 1:38 PM, Graham Yiu <gyiu at ca.ibm.com> wrote: > >> Hi Teresa, >> >> Actually, enabling the new pass manager manually seems to have solved >> this issue, so this problem is only valid for the old pass manager. >> > > It should not be an issue in the old PM either - the callsite hot...

Forgot to add that all experiments were done with '-O3 -m64 -fexperimental-new-pass-manager'. Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Graham Yiu/Toronto/IBM To: llvm-dev at lists.llvm.org Cc: junbuml at codeaurora.org, xinliangli at gmail.com Date: 11/02/2017 05:26 PM Subject: [RFC] Enable Partial Inliner by default Hello, I'd like to propose turning on the partial inliner (-enable-partial-inlining)...

Hi Evgeny, I just realized that if these are compile-time errors I can help investigate on my end. Do you have something I can use to reproduce? Cheers, Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Graham Yiu/Toronto/IBM To: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com> Cc: "junbuml at codeaurora.org" <junbuml at codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, nd <nd at arm...

Hi Teresa, Actually, enabling the new pass manager manually seems to have solved this issue, so this problem is only valid for the old pass manager. Thanks, Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Teresa Johnson <tejohnson at google.com> To: Graham Yiu <gyiu at ca.ibm.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Date: 10/03/2017 04:18 PM Subject: Re: [llvm-dev] PGO information at LTO/thinLTO link step On Tue, Oct 3, 2017 at 12:54 PM, Graham Yiu...

...ing (without inlining to increase the odds of some performance gain). My initial thought was to ditch the new function and its outlined children if we cannot immediately inline it. Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Xinliang David Li <xinliangli at gmail.com> To: Graham Yiu <gyiu at ca.ibm.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Date: 08/24/2017 03:05 PM Subject: Re: [llvm-dev] [RFC] Enhance Partial Inliner by using a general outlining scheme for cold...

...eek. Thanks, Evgeny Astigeevich From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Evgeny Astigeevich via llvm-dev <llvm-dev at lists.llvm.org> Reply-To: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com> Date: Saturday, 11 November 2017 at 17:21 To: Graham Yiu <gyiu at ca.ibm.com> Cc: "junbuml at codeaurora.org" <junbuml at codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Tobias Grosser <tobias.grosser at inf.ethz.ch>, nd <nd at arm.com> Subject: Re: [llvm-dev] [RFC] Enable Partial Inlin...

...with hot/cold attributes during compile step to ensure LTO inlining will give appropriate threshold bonuses/penalties. Any thoughts/insights/comments would be appreciated. Cheers, Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171003/18c2b6f6/attachment.html>

...dify one based on cold region outlining and the other early return peeling, with the latter being our fall-back option if we fail to inline the first clone. What are your thoughts? Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com From: Graham Yiu/Toronto/IBM To: Xinliang David Li <xinliangli at gmail.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Date: 08/15/2017 08:04 PM Subject: Re: [llvm-dev] [RFC] Enhance Partial Inliner by using a general outlining scheme for cold blocks Hey D...

...times the predecessor has to be executed in order for an edge to be considered cold, should also be taken into account to avoid outlining code paths we have little information on. Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-407/8200/Markham Email: gyiu at ca.ibm.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170815/17fc26c9/attachment.html>

...ode size reduction over performance gains. Is my assumption correct? Do you think there's some tuning we can do in the machine outliner to tailor for performance improvements? Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-407/8200/Markham Email: gyiu at ca.ibm.com From: Jessica Paquette <jpaquette at apple.com> To: Graham Yiu <gyiu at ca.ibm.com> Cc: llvm-dev at lists.llvm.org Date: 08/15/2017 02:45 PM Subject: Re: [llvm-dev] [RFC] Enhance Partial Inliner by using a general outlining scheme for cold blocks Sent by: jp...

Hi, I noticed some performance gains in some spec benchmarks without significant code size bloat when aggressively performing partial inlining, especially when the original callee spill CSRs in the entry block. I guess the partial inlining is not enabled mainly due to the code size. Is there any other issue which prevent the pass from being enabled? Do we have any plan or any on-going works

...tion correct? Do you think there's some tuning we can do in the >> machine outliner to tailor for performance improvements? >> >> Graham Yiu >> LLVM Compiler Development >> IBM Toronto Software Lab >> Office: (905) 413-4077 C2-407/8200/Markham >> Email: gyiu at ca.ibm.com >> >> [image: Inactive hide details for Jessica Paquette ---08/15/2017 02:45:06 >> PM---Hi Graham, Have you looked at using the existing outline]Jessica >> Paquette ---08/15/2017 02:45:06 PM---Hi Graham, Have you looked at using >> the existing outliner f...

On Tue, Oct 3, 2017 at 12:08 PM, Davide Italiano <davide at freebsd.org> wrote: > On Tue, Oct 3, 2017 at 11:57 AM, Graham Yiu via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Hello, >> >> I recently noticed that the new pass manager was not enabled at regular/thin >> LTO link step even if '-fexperimental-new-pass-manager' was specified in the

...tasks. I’ll check if the code size issues still exist. Thanks, Evgeny Astigeevich From: Sean Fertile <sd.fertile at gmail.com> Date: Monday, 29 January 2018 at 19:52 To: Florian Hahn <Florian.Hahn at arm.com> Cc: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>, Graham Yiu <gyiu at ca.ibm.com>, "junbuml at codeaurora.org" <junbuml at codeaurora.org>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Tobias Grosser <tobias.grosser at inf.ethz.ch>, nd <nd at arm.com> Subject: Re: [llvm-dev] [RFC] Enable Partial Inliner...

Hello All, This conversations seems to have fizzled out and I would like to try to revive it. My intention is to pick up where Graham left off with enabling partial-inlining by default. On Sat, Dec 9, 2017 at 7:47 AM, Florian Hahn via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi, > > On 13/11/2017 14:47, Evgeny Astigeevich via llvm-dev wrote: > >> Hi Graham,

...;s unclear to me what the preferred method of passing configuration options to LTO/thinLTO link step is. Any insights/thoughts/comments would be greatly appreciated. Cheers, Graham Yiu LLVM Compiler Development IBM Toronto Software Lab Office: (905) 413-4077 C2-707/8200/Markham Email: gyiu at ca.ibm.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20171003/4c253cf7/attachment.html>