llvm dev - Aug 2017 - [5.0.0 Release] Release Candidate 4 tagged

On Wed, Aug 30, 2017 at 2:14 PM, Michał Górny <mgorny at gentoo.org>
wrote:
> W dniu wto, 29.08.2017 o godzinie 16∶52 -0700, użytkownik Hans Wennborg
> via llvm-dev napisał:
>> Hello testers,
>>
>> 5.0.0-rc4 was just tagged.
>>
>> There were very few changes after rc3, and if nothing unexpected comes
>> up, this is what the final release will look like.
>>
>> Please test and let me know if there are any issues.
>>
>
> Mostly green here on Gentoo. Three test problems left:
>
> 1. clang Python bindings are broken due to incomplete commit. I've
> requested its revert in #34386 [1] since this is not something we can
> fix without cooperation of the author, and he's not replying.
:-(
That commit was part of rc1-rc3 too, so I'm sad that we're only
learning about it now.
>From your comment it sounds like one of the tests depends on a module
that was never committed. How come the test hasn't been failing on our
testing and on the bots?

Since this is showing so late, and it only breaks a test, not the
bindings per se, I don't think it's severe enough to block the release
on.

Thanks,
Hans

W dniu śro, 30.08.2017 o godzinie 15∶22 -0700, użytkownik Hans Wennborg
napisał:
> On Wed, Aug 30, 2017 at 2:14 PM, Michał Górny <mgorny at gentoo.org>
wrote:
> > W dniu wto, 29.08.2017 o godzinie 16∶52 -0700, użytkownik Hans
Wennborg
> > via llvm-dev napisał:
> > > Hello testers,
> > > 
> > > 5.0.0-rc4 was just tagged.
> > > 
> > > There were very few changes after rc3, and if nothing unexpected
comes
> > > up, this is what the final release will look like.
> > > 
> > > Please test and let me know if there are any issues.
> > > 
> > 
> > Mostly green here on Gentoo. Three test problems left:
> > 
> > 1. clang Python bindings are broken due to incomplete commit. I've
> > requested its revert in #34386 [1] since this is not something we can
> > fix without cooperation of the author, and he's not replying.
> 
> :-(
> That commit was part of rc1-rc3 too, so I'm sad that we're only
> learning about it now.
I'm sorry. I have reported the issue a month ago and was hoping someone
would actually reply and fix it. Then I forgot about it.
> From your comment it sounds like one of the tests depends on a module
> that was never committed. How come the test hasn't been failing on our
> testing and on the bots?
There are no bots running the Python bindings test suite, and I suppose
nobody is actually running them but people who commit new stuff to
the checks and Gentoo.
> Since this is showing so late, and it only breaks a test, not the
> bindings per se, I don't think it's severe enough to block the
release
> on.
> 
Well, we can always fix it on our end, and hope a fix comes before
5.0.1, or we can revert it then.

-- 
Best regards,
Michał Górny

On Wed, Aug 30, 2017 at 10:22 PM, Michał Górny <mgorny at gentoo.org>
wrote:
> W dniu śro, 30.08.2017 o godzinie 15∶22 -0700, użytkownik Hans Wennborg
> napisał:
>> On Wed, Aug 30, 2017 at 2:14 PM, Michał Górny <mgorny at
gentoo.org> wrote:
>> > W dniu wto, 29.08.2017 o godzinie 16∶52 -0700, użytkownik Hans
Wennborg
>> > via llvm-dev napisał:
>> > > Hello testers,
>> > >
>> > > 5.0.0-rc4 was just tagged.
>> > >
>> > > There were very few changes after rc3, and if nothing
unexpected comes
>> > > up, this is what the final release will look like.
>> > >
>> > > Please test and let me know if there are any issues.
>> > >
>> >
>> > Mostly green here on Gentoo. Three test problems left:
>> >
>> > 1. clang Python bindings are broken due to incomplete commit.
I've
>> > requested its revert in #34386 [1] since this is not something we
can
>> > fix without cooperation of the author, and he's not replying.
>>
>> :-(
>> That commit was part of rc1-rc3 too, so I'm sad that we're only
>> learning about it now.
>
> I'm sorry. I have reported the issue a month ago and was hoping someone
> would actually reply and fix it. Then I forgot about it.
>
>> From your comment it sounds like one of the tests depends on a module
>> that was never committed. How come the test hasn't been failing on
our
>> testing and on the bots?
>
> There are no bots running the Python bindings test suite, and I suppose
> nobody is actually running them but people who commit new stuff to
> the checks and Gentoo.
>
>> Since this is showing so late, and it only breaks a test, not the
>> bindings per se, I don't think it's severe enough to block the
release
>> on.
>>
>
> Well, we can always fix it on our end, and hope a fix comes before
> 5.0.1, or we can revert it then.
Sounds good. I've made a note about it for 5.0.1.

Thanks,
Hans