Krzysztof Parzyszek via llvm-dev
2017-Jul-28 21:17 UTC
[llvm-dev] Tail merging "undef" with a defined register: wrong code
On 7/28/2017 4:00 PM, Quentin Colombet wrote:> I am having a hard time seeing the problem from the example, shouldn’t > we just put an implicit_def at the end of bb.0?That should work actually, even in the general case. I overlooked something when I first said it wouldn't. -Krzysztof -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quentin Colombet via llvm-dev
2017-Jul-28 22:13 UTC
[llvm-dev] Tail merging "undef" with a defined register: wrong code
> On Jul 28, 2017, at 2:17 PM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote: > > On 7/28/2017 4:00 PM, Quentin Colombet wrote: >> I am having a hard time seeing the problem from the example, shouldn’t we just put an implicit_def at the end of bb.0? > > That should work actually, even in the general case. I overlooked something when I first said it wouldn’t.Great!> > -Krzysztof > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Krzysztof Parzyszek via llvm-dev
2017-Aug-01 17:12 UTC
[llvm-dev] Tail merging "undef" with a defined register: wrong code
I ran into the LR/PC issue on ARM again, and the patch has some approach to fixing it. I'm wondering what you think. https://reviews.llvm.org/D36160 -Krzysztof On 7/28/2017 5:13 PM, Quentin Colombet wrote:> >> On Jul 28, 2017, at 2:17 PM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote: >> >> On 7/28/2017 4:00 PM, Quentin Colombet wrote: >>> I am having a hard time seeing the problem from the example, shouldn’t we just put an implicit_def at the end of bb.0? >> >> That should work actually, even in the general case. I overlooked something when I first said it wouldn’t. > > Great! > >> >> -Krzysztof >> >> -- >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation >-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation