Manuel Klimek via llvm-dev
2016-Jun-08 04:16 UTC
[llvm-dev] Allow reopening on Phabricator
If you can find out whether it's possible with the latest phab, I can update our instance. On Tue, Jun 7, 2016, 9:15 PM Tobias Grosser <tobias at grosser.es> wrote:> On 06/07/2016 09:14 PM, Kuba Brecka via llvm-dev wrote: > > From an unrelated thread: > > > >> ... This will need to be fixed before we can commit the patch. Since > >> Phabricator automatically closed http://reviews.llvm.org/D12761, I've > >> created a new revision. The attached diff is a very a slightly > >> modified version of your original patch ... > > > > I have wanted to reopen a Phabricator revision too many times already, > > but couldn’t. I don’t know who the admin of reviews.llvm.org > > <http://reviews.llvm.org> is (CC’ing Chandler as my wild guess). Could > > we configure it so that revisions can be reopened? > > Manuel is the one to CC. > > Tobias > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160608/18d13b70/attachment.html>
http://stackoverflow.com/questions/13633031/how-to-reopen-differential-review-in-phabricator <http://stackoverflow.com/questions/13633031/how-to-reopen-differential-review-in-phabricator> says it’s possible (haven’t tried): • Go to the config section, and chose the differential group. • Find the option differential.allow-reopen • Set value to "Enable reopen" and save config entry. Kuba> On 8 Jun 2016, at 06:16, Manuel Klimek via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > If you can find out whether it's possible with the latest phab, I can update our instance. > > > On Tue, Jun 7, 2016, 9:15 PM Tobias Grosser <tobias at grosser.es <mailto:tobias at grosser.es>> wrote: > On 06/07/2016 09:14 PM, Kuba Brecka via llvm-dev wrote: > > From an unrelated thread: > > > >> ... This will need to be fixed before we can commit the patch. Since > >> Phabricator automatically closed http://reviews.llvm.org/D12761 <http://reviews.llvm.org/D12761>, I've > >> created a new revision. The attached diff is a very a slightly > >> modified version of your original patch ... > > > > I have wanted to reopen a Phabricator revision too many times already, > > but couldn’t. I don’t know who the admin of reviews.llvm.org <http://reviews.llvm.org/> > > <http://reviews.llvm.org <http://reviews.llvm.org/>> is (CC’ing Chandler as my wild guess). Could > > we configure it so that revisions can be reopened? > > Manuel is the one to CC. > > Tobias > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160608/1274f24b/attachment.html>
Manuel Klimek via llvm-dev
2016-Jun-08 11:18 UTC
[llvm-dev] Allow reopening on Phabricator
Thanks. Our instance does indeed already support this. Changed, should work now :D On Wed, Jun 8, 2016 at 1:01 PM Kuba Brecka <jbrecka at apple.com> wrote:> > http://stackoverflow.com/questions/13633031/how-to-reopen-differential-review-in-phabricator says > it’s possible (haven’t tried): > > • Go to the config section, and chose the differential group. > • Find the option differential.allow-reopen > • Set value to "Enable reopen" and save config entry. > > Kuba > > On 8 Jun 2016, at 06:16, Manuel Klimek via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > If you can find out whether it's possible with the latest phab, I can > update our instance. > > On Tue, Jun 7, 2016, 9:15 PM Tobias Grosser <tobias at grosser.es> wrote: > >> On 06/07/2016 09:14 PM, Kuba Brecka via llvm-dev wrote: >> > From an unrelated thread: >> > >> >> ... This will need to be fixed before we can commit the patch. Since >> >> Phabricator automatically closed http://reviews.llvm.org/D12761, I've >> >> created a new revision. The attached diff is a very a slightly >> >> modified version of your original patch ... >> > >> > I have wanted to reopen a Phabricator revision too many times already, >> > but couldn’t. I don’t know who the admin of reviews.llvm.org >> > <http://reviews.llvm.org> is (CC’ing Chandler as my wild guess). Could >> > we configure it so that revisions can be reopened? >> >> Manuel is the one to CC. >> >> Tobias >> >> _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160608/38890031/attachment-0001.html>