Chris Lattner via llvm-dev
2016-Feb-25 21:24 UTC
[llvm-dev] RFC: Move the test-suite LLVM project to GitHub?
> On Feb 25, 2016, at 4:05 AM, Renato Golin via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 25 February 2016 at 11:54, Mehdi Amini <mehdi.amini at apple.com> wrote: >> GitHub offers a simple *raw* git hosting. All the fork&pull-request is sugar in the web interface. You don't *have to* use it. > > I mentioned this below. I was referring how GitHub *expects* to be used.I fundamentally disagree with this (and yes, I am a frequent github user, username=lattner). GitHub supports LLVM style development as it is today (well, but obviously using git instead of svn). A project can maintain a list of committers, and they have direct push access to the repository. This workflow obviously supports the existing “send patch to -commits” or phabricator paths, and people with commit access can apply patches for people without commit access. The vastly superior thing about Github is that it gives you the *ability* to also support pull request. PR’s are totally awesome from a community outreach support, because it drastically lowers that barrier for minor contributions to the project from people who do not have commit access. The workflow is seriously a huge step up from what we do on llvm.org. In any case, while I’m very positive about moving the program testsuite to github, I consider it obvious that anyone with direct commit access to an llvm.org repo would also have direct commit access to the program testsuite, and we’d use the same policies for what kinds of changes are allowed. PR’s would just be a great new workflow to enable new kinds of people to make contributions in an easier way. -Chris
Renato Golin via llvm-dev
2016-Feb-26 14:56 UTC
[llvm-dev] RFC: Move the test-suite LLVM project to GitHub?
On 25 February 2016 at 21:24, Chris Lattner <clattner at apple.com> wrote:>> I mentioned this below. I was referring how GitHub *expects* to be used. > > I fundamentally disagree with this (and yes, I am a frequent github user, username=lattner).Hi Chris, You misread me. I'm not saying (nor advocating) we should use GitHub like that. Just that this is how people think of how to use GitHub. I agree with all your and Chandler's points so far. --renato
Joachim Durchholz via llvm-dev
2016-Feb-26 18:33 UTC
[llvm-dev] RFC: Move the test-suite LLVM project to GitHub?
Am 26.02.2016 um 15:56 schrieb Renato Golin via llvm-dev:> Just that this is how people think of how to use GitHub.People use GitHub the way the project says it should be used. That's why about every GH project has a CONTRIBUTING page or something similar. So that's a non-issue in my book. YMMV. Regards, Jo