Hi, I'm new to LLVM development and I can't find enough information about how to contribute. I've submitted a patch on review as described in the doc: http://llvm.org/docs/Phabricator.html Here is the patch: http://reviews.llvm.org/D4788 The review passed, Phabricator says that the revision is "waiting on me". I've tried to run arc commit on my patch but it responds with 400 error code - Bad Request. Possibly, I just don't have rights for this. What should I do next? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140805/a8955fcd/attachment.html>
On 8/5/14, 9:54 AM, Roman Kashitsyn wrote:> Hi, > > I'm new to LLVM development and I can't find enough information about how to > contribute. I've submitted a patch on review as described in the doc: > http://llvm.org/docs/Phabricator.html > > Here is the patch: > http://reviews.llvm.org/D4788 > > The review passed, Phabricator says that the revision is "waiting on me". I've > tried to run arc commit on my patch but it responds with 400 error code - Bad > Request. > Possibly, I just don't have rights for this. > > What should I do next?Do you have commit access? http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access> > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-- Jon Roelofs jonathan at codesourcery.com CodeSourcery / Mentor Embedded
On 5 August 2014 16:54, Roman Kashitsyn <romankashicin at gmail.com> wrote:> What should I do next?Normally, you'd ask the approver to commit on the first few patches, and after a few good ones you may request commit-after-approval access according to the developer policy. cheers, --renato
2014-08-05 21:36 GMT+04:00 Renato Golin <renato.golin at linaro.org>:> On 5 August 2014 16:54, Roman Kashitsyn <romankashicin at gmail.com> wrote: > > What should I do next? > > Normally, you'd ask the approver to commit on the first few patches, > and after a few good ones you may request commit-after-approval access > according to the developer policy. > >Thank you for clarification. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140805/9b6c1365/attachment.html>