search for: developerpolicy

...ently there's been some friction over reversions (I can remember two cases in recent memory). In both issues the general feel I got is that as a community we should honor "revert for more design review" requests unconditionally. What do you guys think of adding something like this to DeveloperPolicy.rst as an item at the end of the numbered list in http://llvm.org/docs/DeveloperPolicy.html#code-reviews ? #. Sometimes patches get committed that need more discussion. If a developer thinks that a patch would benefit from some more review and promptly communicates this, the patch should be...

Hi all, We branched for the 3.1 release! (Yay!) If there are any fixes which you think should go into the release, please contact the code owners (http://llvm.org/docs/DeveloperPolicy.html#owners) so that they can approve the patches. No patches will be accepted into the 3.1 release without prior approval! This should be a great release! :-) -bw

...code quality and maintenance. It's a small section of the overall tree, and I realize that it is a critical portion that touches virtually the whole project. > > This sounds like a great idea to me. Unless someone objects in the next few days, consider it yours :). Please update docs/DeveloperPolicy to list yourself in the owners section. Thanks Joe, Is there a particular sub-system size that makes sense to mark as owned? I have been reworking the library call simplification infrastructure recently and will be happy to sign up as an owner for that. -- Meador Inge CodeSourcery / Mentor Embe...

.... Add support for Z > We could do each step in individual pull requests but it's unnecessary overhead. I agree that pull requests add additional overhead, but they can be scripted to reduce it. My primary goal is to achieve these things set out in the developer policy: http://llvm.org/docs/DeveloperPolicy.html#incremental-development <http://llvm.org/docs/DeveloperPolicy.html#incremental-development> By making each of these steps explicit PR’s, they get individual testing (when we have integrated presubmit testing, which we’ll hopefully get to), code reviewers are reviewing each atomic step (...

Hi! Some time ago my email address, that I use for committing to LLVM SVN repo has changed (nasty corporate mail changing) and now it's not aligned with email I sent to Chris according to http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access page . Unfortunately it's not possible to forward all messages from LLVM mailing lists from my old address to new one, so I wonder whether I can rebind an email address for my account? Should I ask Chris to change my email? My old address: m.ostapenko at partne...

...l, While committing a patch today for someone who currently lacks commit access, I realized I had forgotten the 'Patch by' line and reverted & re-committed to add it. However, while doing so I wondered if our current policy on this still makes sense. Our policy at http://llvm.org/docs/DeveloperPolicy.html#commit-messages <http://llvm.org/docs/DeveloperPolicy.html#commit-messages> currently contains these two points: > Separate the commit message into title, body and, if you’re not the original author, a “Patch by” attribution line (see below). > Attribution of Changes should be in a...

...so please include me on >> any replies. >> >> I haven't run the tests on this change but would be happy to do so if >> someone could point me to documentation on how to do so. I couldn't >> find testing instructions linked from >> http://llvm.org/docs/**DeveloperPolicy.html<http://llvm.org/docs/DeveloperPolicy.html>. >> I have built the change and >> run it with the programs I was testing originally. With this change the >> crash no longer occurs. >> >> Thanks, >> Joseph Kain >> >> >> _________________...

...hat is, and then, once we have something in, > working and actively helping people add their targets, we can discuss > (in separate) the merits of our current policies. IIUC you are writing specifically that an experimental backend can be integrated without conforming to http://llvm.org/docs/DeveloperPolicy.html#quality <http://llvm.org/docs/DeveloperPolicy.html#quality> ; I don’t think this is a current “policy” but your writing is making it a policy AFAICT. — Mehdi -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/at...

Hi, I've recently submitted a patch to llvm-commits (as requested by https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch) and the mailing list answered with a notice that my message is held for moderator approval (with the reason: "Post by non-member to a members-only list"). I'm therefore wondering if I should've submitted my patch via Phabricator instead (looking...

...9;ve missed any steps. I'm not on the mailing list so please include me on any replies. I haven't run the tests on this change but would be happy to do so if someone could point me to documentation on how to do so. I couldn't find testing instructions linked from http://llvm.org/docs/DeveloperPolicy.html. I have built the change and run it with the programs I was testing originally. With this change the crash no longer occurs. Thanks, Joseph Kain -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130830/...

>From the DeveloperPolicy.html document I gathered I need to send a patch to this list (which I did); could you clarify if I misunderstood it? The second patch is really trivial and I think it's worth applying - it seems like a typo by someone who tested on MSVC 11 but not 10; or maybe my local instance of MSVC10 is som...

...over reversions (I can remember > two cases in recent memory). In both issues the general feel I got > is that as a community we should honor "revert for more design > review" requests unconditionally. > > > What do you guys think of adding something like this to > DeveloperPolicy.rst as an item at the end of the numbered list in > http://llvm.org/docs/DeveloperPolicy.html#code-reviews ? > > > > #. Sometimes patches get committed that need more discussion. > If a developer thinks that a patch would benefit from some more > review > and promptly com...

Hi all, As per the instructions here <http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access>, I contacted Chris Lattner to obtain commit access but haven't received a response (either positive or negative). What's the expected turnaround time for this (I contacted him five days ago)? In case he's currently unavailable, is there someone else I co...

...2012-December/056683.html Michael From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Sergiy Migdalskiy Sent: Thursday, April 18, 2013 10:28 To: David Blaikie Cc: llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] Patch to compile LLVM with MSVC 2010 >From the DeveloperPolicy.html<http://llvm.org/docs/DeveloperPolicy.html> document I gathered I need to send a patch to this list (which I did); could you clarify if I misunderstood it? The second patch is really trivial and I think it's worth applying - it seems like a typo by someone who tested on MSVC 11 but n...

...ality and maintenance. It's a small section of the overall tree, and I realize that it is a critical portion that touches virtually the whole project. >> >> This sounds like a great idea to me. Unless someone objects in the next few days, consider it yours :). Please update docs/DeveloperPolicy to list yourself in the owners section. Thanks Joe, > > Is there a particular sub-system size that makes sense to mark as owned? I have been reworking the library call > simplification infrastructure recently and will be happy to sign up as an owner for that. I think that "directo...

...been discussed from time to time, so it's not too > surprising that people have different ideas of what the policy is. > > Maybe documenting the release-numbering-semantics policy alongside > the release-timing policy would be a good idea? It is documented at http://llvm.org/docs/DeveloperPolicy.html#ir-backwards-compatibility Cheers, Rafael

Hi, https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access still describes the SVN process. How do things work now that we're on github? Nico -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191101/7bc2d459/attachment.html>

...have a centralized repo with a mainline branch that everybody pushes to This one. > , or the a linux style model where some person has an official mainline to which he pulls? Not this one. This shouldn't be a mysterious concept, our policies are well documented here: http://llvm.org/docs/DeveloperPolicy.html#policies -Chris

...;m not on the mailing list so please include me on > any replies. > > I haven't run the tests on this change but would be happy to do so if > someone could point me to documentation on how to do so. I couldn't > find testing instructions linked from > http://llvm.org/docs/DeveloperPolicy.html. I have built the change and > run it with the programs I was testing originally. With this change the > crash no longer occurs. > > Thanks, > Joseph Kain > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.e...

Hello, I was curious if there was any advice on how to get a code-review restarted/completed. The two I've submitted recently (D30107<https://reviews.llvm.org/D30107> D29923<https://reviews.llvm.org/D29923>) have gotten a bit of review but both then seem to stall. Any hints? Thanks. -------------- next part -------------- An HTML attachment was scrubbed... URL: