On Wed, Jun 25, 2014 at 3:30 PM, John Criswell <criswell at illinois.edu> wrote:> On 6/25/14, 5:15 PM, Vadim Chugunov wrote: > > In a recent review via Phabricator, I was receiving bounce notifications for > mail being sent to llvm-commits because of "Too many recipients to the > message", even though I am a subscriber. I wonder how common is that. > > > Someone else emailed about that to me earlier today. > > The current limit is set at 10 for llvm-commits. It sounds like that is too > low. > > Does anyone that uses Phabricator have an idea of how much to increase this > limit? Would 20 suffice, or are more people than that CC'ed on Phabricator > emails?I'm not exactly sure why Phab should need a higher limit. I've seen a few Phab emails come through with a list as long as my arm - but I don't know why that happens. Anyone know where those are coming from? Maybe it's people using Herald to subscribe to changes in particular parts of the codebase - so when someone starts a code review all the Herald subscribers end up cc'd on the initial mail? I wonder if the Herald subscribers should be bcc'd or handled in some other way? If that's what's happening, and it's the right way to do it, I'm not sure what the right limit is - as more people use Herald we could get larger and larger CC lists. What's the mailing list limit for? What're the tradeoffs of setting it higher, or removing it entirely? - David
I use Herald and find it very useful to keep an eye on certain types of commits, and it seems more people are using it in this way. I don't see any reason why Herald wouldn't be able to bcc instead of cc, as long as people use the web-ui or reply to phabricator directly then they should still receive updates when the review changes. I have no idea whether Herald supports that though. Amara On 26 June 2014 00:00, David Blaikie <dblaikie at gmail.com> wrote:> On Wed, Jun 25, 2014 at 3:30 PM, John Criswell <criswell at illinois.edu> wrote: >> On 6/25/14, 5:15 PM, Vadim Chugunov wrote: >> >> In a recent review via Phabricator, I was receiving bounce notifications for >> mail being sent to llvm-commits because of "Too many recipients to the >> message", even though I am a subscriber. I wonder how common is that. >> >> >> Someone else emailed about that to me earlier today. >> >> The current limit is set at 10 for llvm-commits. It sounds like that is too >> low. >> >> Does anyone that uses Phabricator have an idea of how much to increase this >> limit? Would 20 suffice, or are more people than that CC'ed on Phabricator >> emails? > > I'm not exactly sure why Phab should need a higher limit. I've seen a > few Phab emails come through with a list as long as my arm - but I > don't know why that happens. Anyone know where those are coming from? > > Maybe it's people using Herald to subscribe to changes in particular > parts of the codebase - so when someone starts a code review all the > Herald subscribers end up cc'd on the initial mail? I wonder if the > Herald subscribers should be bcc'd or handled in some other way? > > If that's what's happening, and it's the right way to do it, I'm not > sure what the right limit is - as more people use Herald we could get > larger and larger CC lists. > > What's the mailing list limit for? What're the tradeoffs of setting it > higher, or removing it entirely? > > - David > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On Wed, Jun 25, 2014 at 4:00 PM, David Blaikie <dblaikie at gmail.com> wrote:> On Wed, Jun 25, 2014 at 3:30 PM, John Criswell <criswell at illinois.edu> wrote: >> On 6/25/14, 5:15 PM, Vadim Chugunov wrote: >> >> In a recent review via Phabricator, I was receiving bounce notifications for >> mail being sent to llvm-commits because of "Too many recipients to the >> message", even though I am a subscriber. I wonder how common is that. >> >> >> Someone else emailed about that to me earlier today. >> >> The current limit is set at 10 for llvm-commits. It sounds like that is too >> low. >> >> Does anyone that uses Phabricator have an idea of how much to increase this >> limit? Would 20 suffice, or are more people than that CC'ed on Phabricator >> emails? > > I'm not exactly sure why Phab should need a higher limit. I've seen a > few Phab emails come through with a list as long as my arm - but I > don't know why that happens. Anyone know where those are coming from? >In my case a person that put up a patch put everyone they knew into the reviewer field to get a lot of eyes on it. It overran the limit :)> Maybe it's people using Herald to subscribe to changes in particular > parts of the codebase - so when someone starts a code review all the > Herald subscribers end up cc'd on the initial mail? I wonder if the > Herald subscribers should be bcc'd or handled in some other way? > > If that's what's happening, and it's the right way to do it, I'm not > sure what the right limit is - as more people use Herald we could get > larger and larger CC lists. > > What's the mailing list limit for? What're the tradeoffs of setting it > higher, or removing it entirely? >A spam precaution like the others :) -eric
I have seen the "Too many recipients to the message" several times. A limit of 10 includes the patch author and the list leaving just 8 subscribers/reviewers is way too low. Given that these e-mails can be sent only by a Phab. user I'm not sure that spam is a problem at all: A potential spammer would first have to subscribe to Phab. then create a proper diff,... far easier just to spam-mail everyone. Yaron 2014-06-26 3:15 GMT+03:00 Eric Christopher <echristo at gmail.com>:> On Wed, Jun 25, 2014 at 4:00 PM, David Blaikie <dblaikie at gmail.com> wrote: > > On Wed, Jun 25, 2014 at 3:30 PM, John Criswell <criswell at illinois.edu> > wrote: > >> On 6/25/14, 5:15 PM, Vadim Chugunov wrote: > >> > >> In a recent review via Phabricator, I was receiving bounce > notifications for > >> mail being sent to llvm-commits because of "Too many recipients to the > >> message", even though I am a subscriber. I wonder how common is that. > >> > >> > >> Someone else emailed about that to me earlier today. > >> > >> The current limit is set at 10 for llvm-commits. It sounds like that > is too > >> low. > >> > >> Does anyone that uses Phabricator have an idea of how much to increase > this > >> limit? Would 20 suffice, or are more people than that CC'ed on > Phabricator > >> emails? > > > > I'm not exactly sure why Phab should need a higher limit. I've seen a > > few Phab emails come through with a list as long as my arm - but I > > don't know why that happens. Anyone know where those are coming from? > > > > In my case a person that put up a patch put everyone they knew into > the reviewer field to get a lot of eyes on it. It overran the limit :) > > > Maybe it's people using Herald to subscribe to changes in particular > > parts of the codebase - so when someone starts a code review all the > > Herald subscribers end up cc'd on the initial mail? I wonder if the > > Herald subscribers should be bcc'd or handled in some other way? > > > > If that's what's happening, and it's the right way to do it, I'm not > > sure what the right limit is - as more people use Herald we could get > > larger and larger CC lists. > > > > What's the mailing list limit for? What're the tradeoffs of setting it > > higher, or removing it entirely? > > > > A spam precaution like the others :) > > -eric > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140626/32ce8b8f/attachment.html>