search for: keren

...nt raw_svector_ostream. Would you prefer to continue review on Phabricator? 2015-07-11 20:48 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>: > This makes write virtual. What is the impact of that on the other > streamers? > > > > On 22 May 2015 at 10:17, Yaron Keren <yaron.keren at gmail.com> wrote: > > Here's a performance testcase for the raw_svector_ostream patch. On my > > WIndows x64 machine it runs in 1010ms with the current code and in 440ms > > with the patch applies. Is this OK to commit? > > > > > > 2015-...

...fael.espindola at gmail.com>: > Given that it is faster, I am OK with it. > > I get 0.774371631s with master and 0.649787169s with your patch. > > Why move all virtual functions to the header? LGTM with them still in > the .cpp file. > > On 12 August 2015 at 01:53, Yaron Keren <yaron.keren at gmail.com> wrote: > > +llvm-dev at lists.llvm.org > > > > The impact should be small as all the other streamers usually write > directly > > to the memory buffer and only when out of buffer they call write(). > > > > OTOH, raw_svector_ost...

Here's a performance testcase for the raw_svector_ostream patch. On my WIndows x64 machine it runs in 1010ms with the current code and in 440ms with the patch applies. Is this OK to commit? 2015-05-02 21:31 GMT+03:00 Yaron Keren <yaron.keren at gmail.com>: > Following a hint from Duncan in http://llvm.org/pr23395, here is a > revised patch. Rather then introduce the raw_char_ostream adapter, this > version improves raw_svector_ostream. > > raw_svector_ostream is now a very lightweight adapter, running...

...t; > > Fraunhofer-Institut für Graphische Datenverarbeitung IGD > > Fraunhoferstr. 5 | 64283 Darmstadt | Germany > > Tel +49 6151 155-606 | Fax +49 6151 155-139 > > johannes.mueller-roemer at igd.fraunhofer.de | www.igd.fraunhofer.de > > > > *From:* Yaron Keren [mailto:yaron.keren at gmail.com] > *Sent:* Friday, May 29, 2015 08:59 > *To:* Mueller-Roemer, Johannes Sebastian > *Cc:* Chris Bieneman; LLVM Developers Mailing List > > *Subject:* Re: [LLVMdev] [RFC] Late May Update: Progress report on CMake > build system's ability to repla...

...s of output type, I had meant to file a bug about this but > had apparently forgotten to do so. I think the check needs to be that the > target is Windows and ignore the output type, Linux and OSX don't use this. > > Cheers, > Andrew > On Wed, Oct 23, 2013 at 11:32 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > YES, this is the problem! > > The program work ok, even a 5x larger version works well. > > Clearly the _chkstk calls must be emitted with ELF target on Windows as > well - why not? > > I'd like to make a patch and fix this righ...

...| Fax +49 6151 155-139 > > johannes.mueller-roemer at igd.fraunhofer.de | www.igd.fraunhofer.de > > > > *From:* llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] *On > Behalf Of *Chris Bieneman > *Sent:* Thursday, May 28, 2015 22:36 > *To:* Yaron Keren > *Cc:* LLVM Developers Mailing List > *Subject:* Re: [LLVMdev] [RFC] Late May Update: Progress report on CMake > build system's ability to replace autoconf > > > > I sent out a patch for review. > > > > http://reviews.llvm.org/D10102 > <https://urldefense...

This is the right fix if Cygwin wants calls to __chkstk. Otherwise you'll want TargetTriple.isOSMSVCRT(). On Wed, Oct 23, 2013 at 2:50 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > If it's a Windows-only thing the correct tests would be: > > if (NumBytes >= 4096 && STI.isOSWindows()) { > > and > > if (Subtarget->isTargetWindows()) > > where > > bool isOSWindows() const { retur...

...he check-all (this check-all runs with self-build-clang): Failing Tests (2): Clang Tools :: clang-tidy/clang-tidy-diff.cpp Clang Tools :: clang-tidy/file-filter.cpp Last log: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/340/steps/ninja%20check%202/logs/stdio From: Yaron Keren [mailto:yaron.keren at gmail.com] Sent: Thursday, April 23, 2015 12:27 To: Paweł Bylica Cc: Fedorova, Vera; llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] Buildbot for Windows native LLVM/Clang testing r235576 Window7 Visual C++ 2013 x64 just passed regression OK on my system. 2015-04-23 12:19 GM...

I sent out a patch for review. http://reviews.llvm.org/D10102 <http://reviews.llvm.org/D10102> -Chris > On May 28, 2015, at 9:48 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > > Thanks! > > 2015-05-28 18:56 GMT+03:00 Chris Bieneman <beanz at apple.com <mailto:beanz at apple.com>>: > >> On May 28, 2015, at 8:37 AM, Yaron Keren <yaron.keren at gmail.com <mailto:yaron.keren at gmail.com>&...

...Wiss. Mitarbeiter - Interactive Engineering Technologies (IET) Fraunhofer-Institut für Graphische Datenverarbeitung IGD Fraunhoferstr. 5 | 64283 Darmstadt | Germany Tel +49 6151 155-606 | Fax +49 6151 155-139 johannes.mueller-roemer at igd.fraunhofer.de | www.igd.fraunhofer.de From: Yaron Keren [mailto:yaron.keren at gmail.com] Sent: Friday, May 29, 2015 08:59 To: Mueller-Roemer, Johannes Sebastian Cc: Chris Bieneman; LLVM Developers Mailing List Subject: Re: [LLVMdev] [RFC] Late May Update: Progress report on CMake build system's ability to replace autoconf Both Release and $CONFIG...

...> If you take a look for isTargetCOFF() in > lib/Target/X86/X86ISelLowering.cpp and lib/Target/X86/X86FrameLowering.cpp > you should be able to remove that check to force __chkstk output to see if > that helps. > > Cheers, > Andrew > On Wed, Oct 23, 2013 at 1:22 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > Yes, this is correct code address accessing bad data address. > > However, there is no other relocation before .text or near it. I'll send > you the full debug printout, maybe you'll note something. > > The problem could be result...

...results. BTW, I've tried to quantify the slowdown: a quick test indicates that LLVM build that uses pthreads is about 10% slower than the one which doesn't. This is less that I remember seeing last year (something got optimized?), but still... Vadim On Fri, Sep 26, 2014 at 3:29 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > Yes, of course. > > I refer to the significant slowdown of Rust compiler when compiled with > -pthreads vs -win32threads flavor. > If Rust can be compiled without <mutex> and <thread> on win32threads, why > should it slow dow...

...required on Windows regardless of output type, I had meant to file a bug about this but had apparently forgotten to do so. I think the check needs to be that the target is Windows and ignore the output type, Linux and OSX don't use this. Cheers, Andrew On Wed, Oct 23, 2013 at 11:32 AM, Yaron Keren <yaron.keren at gmail.com> wrote: > YES, this is the problem! > > The program work ok, even a 5x larger version works well. > > Clearly the _chkstk calls must be emitted with ELF target on Windows as > well - why not? > > I'd like to make a patch and fix this righ...

2015-05-03 21:02 GMT+09:00 Yaron Keren <yaron.keren at gmail.com>: > I now tried the extra tests and get the same failures: > > Clang Tools :: clang-tidy/clang-tidy-diff.cpp > Clang Tools :: clang-tidy/file-filter.cpp > > Takumi, I see you added requires:shell in r211831 and r220837. > > When using...

...| 64283 Darmstadt | Germany Tel +49 6151 155-606 | Fax +49 6151 155-139 johannes.mueller-roemer at igd.fraunhofer.de | www.igd.fraunhofer.de From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Chris Bieneman Sent: Thursday, May 28, 2015 22:36 To: Yaron Keren Cc: LLVM Developers Mailing List Subject: Re: [LLVMdev] [RFC] Late May Update: Progress report on CMake build system's ability to replace autoconf I sent out a patch for review. http://reviews.llvm.org/D10102<https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10102&d...

...gt; problems, but you should see an assertion in that case. That can happen if > we weren’t able to get the address we requested from allocateMappedMemory, > but it doesn’t look like that’s what’s happening here.**** > > ** ** > > -Andy**** > > ** ** > > *From:* Yaron Keren [mailto:yaron.keren at gmail.com] > *Sent:* Tuesday, October 22, 2013 1:41 PM > > *To:* Kaylor, Andrew > *Cc:* <llvmdev at cs.uiuc.edu> > *Subject:* Re: Size limitations in MCJIT / ELF Dynamic Linker/ ELF > codegen?**** > > ** ** > > Hi,**** > > ** ** >...

...t would be a potential problem spot, but it shouldn’t be > generating any stubs. So the obvious thing to look at is whether any of > the relocations are writing to the spot where the crash occurs.**** > > ** ** > > -Andy**** > > ** ** > > ** ** > > *From:* Yaron Keren [mailto:yaron.keren at gmail.com] > *Sent:* Tuesday, October 22, 2013 10:17 AM > *To:* Kaylor, Andrew > *Cc:* <llvmdev at cs.uiuc.edu> > *Subject:* Re: Size limitations in MCJIT / ELF Dynamic Linker/ ELF > codegen?**** > > ** ** > > OS is Windows 7 64 bit OS, compil...

I agree, it is great. I have some regression tests (check-all) failures on Windows locally. Does the buildbot show the same? On Thu, Apr 23, 2015 at 11:16 AM Yaron Keren <yaron.keren at gmail.com> wrote: > That's great to hear! > > 2015-04-23 12:08 GMT+03:00 Fedorova, Vera <vera.fedorova at intel.com>: > >> Hi All, >> >> >> >> This is to let you know that a new buildbot for Windows native LLVM/Clang >&g...

+update diff 2015-05-02 7:38 GMT+03:00 Yaron Keren <yaron.keren at gmail.com>: > I outlined (is that the right > word?) raw_char_ostream::grow, raw_char_ostream::write (both) into > raw_ostream.cpp with less than 10% difference in performance. > > Profiling reveals that the real culprit is the code line > > OS.reserve(O...

...at addresses that are more than 2GB apart we'll have problems, but you should see an assertion in that case. That can happen if we weren't able to get the address we requested from allocateMappedMemory, but it doesn't look like that's what's happening here. -Andy From: Yaron Keren [mailto:yaron.keren at gmail.com] Sent: Tuesday, October 22, 2013 1:41 PM To: Kaylor, Andrew Cc: <llvmdev at cs.uiuc.edu> Subject: Re: Size limitations in MCJIT / ELF Dynamic Linker/ ELF codegen? Hi, Thanks for your ideas. Memory allocation already exceeds 2x64K in the "working"...