Joshua Magee
2013-Dec-17 04:11 UTC
[LLVMdev] Out of tree targets: API Change to MFI::CreateStackObject
Hi, I will soon be committing a change to MachineFrameInfo::CreateStackObject that removes the "bool MayNeedSP" parameter. This API change is part of larger patch that re-works stack layout passes to use analysis from the StackProtector pass to layout StackProtected objects (http://llvm-reviews.chandlerc.com/D2158). Out of tree targets will need to update their usage accordingly. The most likely scenarios will be along these lines: - CreateStackObject(Size, Alignment, false /*isSS*/, false /*MayNeedSP*/); + CreateStackObject(Size, Alignment, false /*isSS*/); Or: - CreateStackObject(Size, Alignment, false /*isSS*/, false /*MayNeedSP*/, AI); + CreateStackObject(Size, Alignment, false /*isSS*/, AI); Thanks, - Josh
Joshua Magee
2013-Dec-19 03:36 UTC
[LLVMdev] Out of tree targets: API Change to MFI::CreateStackObject
Committed @ r197653. At 1387253492 seconds past the Epoch, Joshua Magee wrote:> Hi, > > I will soon be committing a change to MachineFrameInfo::CreateStackObject > that removes the "bool MayNeedSP" parameter. This API change is part of larger > patch that re-works stack layout passes to use analysis from the StackProtector > pass to layout StackProtected objects (http://llvm-reviews.chandlerc.com/D2158). > > Out of tree targets will need to update their usage accordingly. The most > likely scenarios will be along these lines: > - CreateStackObject(Size, Alignment, false /*isSS*/, false /*MayNeedSP*/); > + CreateStackObject(Size, Alignment, false /*isSS*/); > > Or: > - CreateStackObject(Size, Alignment, false /*isSS*/, false /*MayNeedSP*/, AI); > + CreateStackObject(Size, Alignment, false /*isSS*/, AI); > > Thanks, > - Josh > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >