My understand is that in DAG terminology, Flag is now called Glue. It would be nice for someone to go through and clean up the code as far as comments and variable names. That was driving me close to the brink of insanity till I found out about this. Even in Selection Dag Node Properties def SDNPOutGlue : SDNodeProperty; // Write a flag result def SDNPInGlue : SDNodeProperty; // Read a flag operand def SDNPOptInGlue : SDNodeProperty; // Optionally read a flag operand
A similar casualty is that we have a bunch of nonsensically named variables `const DataLayout *TD` as residue from the TargetData -> DataLayout transition :| -- Sean Silva -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130415/17355dab/attachment.html>
On Apr 15, 2013, at 4:50 PM, Sean Silva <silvas at purdue.edu> wrote:> A similar casualty is that we have a bunch of nonsensically named variables `const DataLayout *TD` as residue from the TargetData -> DataLayout transition :|Patches that fix these sorts of issues are pre-approved. Go for it :-) -Chris
On Mon, Apr 15, 2013 at 4:50 PM, Sean Silva <silvas at purdue.edu> wrote:> A similar casualty is that we have a bunch of nonsensically named > variables `const DataLayout *TD` as residue from the TargetData -> > DataLayout transition :| >Good catch! I kicked off with 179601 fixing it in the DataLayout class itself. Eli -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130416/6ad3c970/attachment.html>