llvm dev - Feb 2013 - [LLVMdev] GCMetadataPrinter::finishAssembly not executed?

Pedro, Yiannis,

What's about the usage case, when LLVM is used as a library and the user
implements its custom pass, which dump the code (implemented as a
FunctionPass, but not as Printer)?

You also missed in your changes the declaration
of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h

-Dmitry.

On Mon, Feb 18, 2013 at 9:34 PM, Pedro Artigas <partigas at apple.com>
wrote:
>
> Hello Yiannis,
>
> Your patch seems fine. It is option #2 which I am glad to hear solves the
> issue. It also removes more lines than it adds, I like patches that fix
> issues and have that property!
>
> Anyhow if you add some testing, as you suggest, you should be good to go.
>
> Thanks
>
> Pedro
>
> On Feb 16, 2013, at 6:13 AM, Yiannis Tsiouris <gtsiour at
softlab.ntua.gr>
> wrote:
>
> > <GCMetadata.patch>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130223/7d51b8cd/attachment.html>

HelloAll,

I am not an expert in CG but if the printer has to delete the info explicitly I
believe any other client would have to do the same, I do not believe this has
changed with Yiannis change.

Oh … true … there is that to delete too …

Pedro

On Feb 23, 2013, at 9:10 AM, Dmitry Babokin <babokin at gmail.com> wrote:
> Pedro, Yiannis,
> 
> What's about the usage case, when LLVM is used as a library and the
user implements its custom pass, which dump the code (implemented as a
FunctionPass, but not as Printer)?
> 
> You also missed in your changes the declaration of
llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h
> 
> -Dmitry.
> 
> On Mon, Feb 18, 2013 at 9:34 PM, Pedro Artigas <partigas at
apple.com> wrote:
> 
> Hello Yiannis,
> 
> Your patch seems fine. It is option #2 which I am glad to hear solves the
issue. It also removes more lines than it adds, I like patches that fix issues
and have that property!
> 
> Anyhow if you add some testing, as you suggest, you should be good to go.
> 
> Thanks
> 
> Pedro
> 
> On Feb 16, 2013, at 6:13 AM, Yiannis Tsiouris <gtsiour at
softlab.ntua.gr> wrote:
> 
> > <GCMetadata.patch>
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130225/3c51f2a3/attachment.html>

Hi Dmitry,

On 02/23/13 19:10, Dmitry Babokin wrote:
> What's about the usage case, when LLVM is used as a library and the 
> user implements its custom pass, which dump the code (implemented as a 
> FunctionPass, but not as Printer)?
Hm, I haven't thought of that... I'll take a better look and try to find
a more suitable solution. Any suggestion is more than welcome! :-)
> You also missed in your changes the declaration 
> of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h
Oops, sorry! I suppose I missed that! Pedro, will you take care of that 
(by just removing it) or should I sent a trivial fix in llvm-commits 
(where I don't have direct commit access)?

yiannis

-- 
Yiannis Tsiouris
Ph.D. student,
Software Engineering Laboratory,
National Technical University of Athens
WWW: http://www.softlab.ntua.gr/~gtsiour

Yiannis, Pedro,

I'm not an expert here. Taking closer look I see that it makes sense to do
this cleanup job in doFinalization() of the pass, which requested GC info.
So the current fix seems to be ok and all external clients will need to do
cleanup directly doing the same jobs as Printer::doFinalization() does now.

By the way, I've just noticed that comments for GCModuleInfo::clear() also
needs to be updated, as it mentions deleter pass.

-Dmitry.

On Mon, Feb 25, 2013 at 9:55 PM, Yiannis Tsiouris
<gtsiour at softlab.ntua.gr>wrote:
> Hi Dmitry,
>
>
> On 02/23/13 19:10, Dmitry Babokin wrote:
>
>> What's about the usage case, when LLVM is used as a library and the
user
>> implements its custom pass, which dump the code (implemented as a
>> FunctionPass, but not as Printer)?
>>
> Hm, I haven't thought of that... I'll take a better look and try to
find a
> more suitable solution. Any suggestion is more than welcome! :-)
>
>
>  You also missed in your changes the declaration of
>> llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h
>>
> Oops, sorry! I suppose I missed that! Pedro, will you take care of that
> (by just removing it) or should I sent a trivial fix in llvm-commits (where
> I don't have direct commit access)?
>
> yiannis
>
>
> --
> Yiannis Tsiouris
> Ph.D. student,
> Software Engineering Laboratory,
> National Technical University of Athens
> WWW:
http://www.softlab.ntua.gr/~**gtsiour<http://www.softlab.ntua.gr/~gtsiour>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130225/6b16ea0c/attachment.html>