search for: creategcinfodeleter

Pedro, Yiannis, What's about the usage case, when LLVM is used as a library and the user implements its custom pass, which dump the code (implemented as a FunctionPass, but not as Printer)? You also missed in your changes the declaration of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h -Dmitry. On Mon, Feb 18, 2013 at 9:34 PM, Pedro Artigas <partigas at apple.com> wrote: > > Hello Yiannis, > > Your patch seems fine. It is option #2 which I am glad to hear solves the > issue. It also removes more lines than it adds, I like...

...d as a >> FunctionPass, but not as Printer)? >> > Hm, I haven't thought of that... I'll take a better look and try to find a > more suitable solution. Any suggestion is more than welcome! :-) > > > You also missed in your changes the declaration of >> llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h >> > Oops, sorry! I suppose I missed that! Pedro, will you take care of that > (by just removing it) or should I sent a trivial fix in llvm-commits (where > I don't have direct commit access)? > > yiannis > > > -- > Yiannis Tsi...

...s, which dump the code (implemented as a > FunctionPass, but not as Printer)? Hm, I haven't thought of that... I'll take a better look and try to find a more suitable solution. Any suggestion is more than welcome! :-) > You also missed in your changes the declaration > of llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h Oops, sorry! I suppose I missed that! Pedro, will you take care of that (by just removing it) or should I sent a trivial fix in llvm-commits (where I don't have direct commit access)? yiannis -- Yiannis Tsiouris Ph.D. student, Software Engineering Laborat...

...Pass, but not as Printer)? > > Hm, I haven't thought of that... I'll take a better look and try > to find a more suitable solution. Any suggestion is more than > welcome! :-) > > > You also missed in your changes the declaration of > llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h > > Oops, sorry! I suppose I missed that! Pedro, will you take care of > that (by just removing it) or should I sent a trivial fix in > llvm-commits (where I don't have direct commit access)? > -- Yiannis Tsiouris Ph.D. student, Sof...

Hello Yiannis, Your patch seems fine. It is option #2 which I am glad to hear solves the issue. It also removes more lines than it adds, I like patches that fix issues and have that property! Anyhow if you add some testing, as you suggest, you should be good to go. Thanks Pedro On Feb 16, 2013, at 6:13 AM, Yiannis Tsiouris <gtsiour at softlab.ntua.gr> wrote: >

...but not as Printer)? >>> >> Hm, I haven't thought of that... I'll take a better look and try to find >> a more suitable solution. Any suggestion is more than welcome! :-) >> >> >> You also missed in your changes the declaration of >>> llvm::createGCInfoDeleter() in include/llvm/CodeGen/Passes.h >>> >> Oops, sorry! I suppose I missed that! Pedro, will you take care of that >> (by just removing it) or should I sent a trivial fix in llvm-commits (where >> I don't have direct commit access)? >> > -- > Yiannis Tsi...

On 02/15/2013 07:13 PM, Pedro Artigas wrote: > I am not an expert on metadata or the CG information but one of the two has to happen: I'm not an expert either but I'll give it a try! :-) > - Simply moving the deleter pass to a different spot > - Changing the doFinalization of another pass (Printer?) to do the deleter pass job (this should work now because the doFinalization order

...(gpu == "SI") { > + PM.add(createSICodeEmitterPass(Out)); > + } else if (Subtarget.device()->getGeneration() <= AMDILDeviceInfo::HD6XXX) { > + PM.add(createR600CodeEmitterPass(Out)); > + } else { > + abort(); > + return true; > + } > + PM.add(createGCInfoDeleter()); > + > + return false; > +} > + > +namespace { > +class AMDGPUPassConfig : public TargetPassConfig { > +public: > + AMDGPUPassConfig(AMDGPUTargetMachine *TM, PassManagerBase &PM) > + : TargetPassConfig(TM, PM) {} > + > + AMDGPUTargetMachine &getAMDG...