llvm dev - Oct 2012 - [LLVMdev] TargetELFWriterInfo used for anything?

On Fri, Oct 26, 2012 at 6:01 PM, 陳韋任 (Wei-Ren Chen) <
chenwj at iis.sinica.edu.tw> wrote:
> Hi Jan,
>
>   Why do you think TargetELFWriterInfo is not used (IIUC)?
> I see a lot of targets inherit class TargetELFWriterInfo
> for their ELF writer.
>
>
Yes, a lot of targets inherit it, but it looks like nothing ever
calls getELFWriterInfo() (anymore) to get access to the instances.


> Regards,
> chenwj
>
> --
> Wei-Ren Chen (陳韋任)
> Computer Systems Lab, Institute of Information Science,
> Academia Sinica, Taiwan (R.O.C.)
> Tel:886-2-2788-3799 #1667
> Homepage: http://people.cs.nctu.edu.tw/~chenwj
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121026/91a268b7/attachment.html>

2012/10/27 Jan Voung <jvoung at chromium.org>:
> On Fri, Oct 26, 2012 at 6:01 PM, ��f�� (Wei-Ren Chen)
> <chenwj at iis.sinica.edu.tw> wrote:
>>
>> Hi Jan,
>>
>>   Why do you think TargetELFWriterInfo is not used (IIUC)?
>> I see a lot of targets inherit class TargetELFWriterInfo
>> for their ELF writer.
>>
>
> Yes, a lot of targets inherit it, but it looks like nothing ever
> calls getELFWriterInfo() (anymore) to get access to the instances.
>
Via greping, I find that it is only used in XXXTargetMachine class.
Obviously its codes overlap with those in XXXELFObjectWriter class.

In consideration of those codes in XXXAsmPrinter class which print out
MachineInstr in .s format, I tend to think they are old codes that
might be obsolete and will be replaced with MC layer implementation,
but I am not sure.

Hope someone authoritative answer this question.

Regards.
>
>>
>> Regards,
>> chenwj
>>
>> --
>> Wei-Ren Chen (��f��)
>> Computer Systems Lab, Institute of Information Science,
>> Academia Sinica, Taiwan (R.O.C.)
>> Tel:886-2-2788-3799 #1667
>> Homepage: http://people.cs.nctu.edu.tw/~chenwj
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>


-- 
������ (Yang Yongyong)

> In consideration of those codes in XXXAsmPrinter class which print out
> MachineInstr in .s format, I tend to think they are old codes that
> might be obsolete and will be replaced with MC layer implementation,
> but I am not sure.
  How about sending a patch which remove those obsolete code, and let
others give comment?

Cheers,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj