Perhaps it could have been removed when ELFWriter was removed in r147615? http://llvm.org/viewvc/llvm-project?view=rev&revision=147615 - Jan On Fri, Oct 26, 2012 at 4:41 PM, Jan Voung <jvoung at chromium.org> wrote:> Oops, sorry hit send too early -- meant to just make a draft email. I'm > still looking through, but so far I hadn't seen many of its methods being > used... > > > On Fri, Oct 26, 2012 at 4:37 PM, Jan Voung <jvoung at chromium.org> wrote: > >> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121026/b9dc54c8/attachment.html>
Hi Jan, Why do you think TargetELFWriterInfo is not used (IIUC)? I see a lot of targets inherit class TargetELFWriterInfo for their ELF writer. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj
On Fri, Oct 26, 2012 at 6:01 PM, 陳韋任 (Wei-Ren Chen) < chenwj at iis.sinica.edu.tw> wrote:> Hi Jan, > > Why do you think TargetELFWriterInfo is not used (IIUC)? > I see a lot of targets inherit class TargetELFWriterInfo > for their ELF writer. > >Yes, a lot of targets inherit it, but it looks like nothing ever calls getELFWriterInfo() (anymore) to get access to the instances.> Regards, > chenwj > > -- > Wei-Ren Chen (陳韋任) > Computer Systems Lab, Institute of Information Science, > Academia Sinica, Taiwan (R.O.C.) > Tel:886-2-2788-3799 #1667 > Homepage: http://people.cs.nctu.edu.tw/~chenwj >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121026/91a268b7/attachment.html>