llvm dev - Oct 2012 - [LLVMdev] [cfe-dev] Announcement: Phabricator for code reviews

On Fri, Oct 19, 2012 at 1:05 AM, Michael Spencer <bigcheesegs at
gmail.com>wrote:
> On Wed, Oct 17, 2012 at 10:18 AM, Manuel Klimek <klimek at
google.com> wrote:
> > Dear LLVM / Clang community,
> >
> > we'd like to open the use of Phabricator as an optional tool for
doing
> code
> > reviews to a wider audience. Please feel free to start your code
reviews
> by
> > following the documentation at http://llvm.org/docs/Phabricator.html.
> >
> > Note that e-mail is still the reference medium for code reviews.
Please
> let
> > me know about any problems with Phabricator or the documentation you
> find.
> >
> > Cheers,
> > /Manuel
> >
> > _______________________________________________
> > cfe-dev mailing list
> > cfe-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> >
>
> One minor issue with the patch I just sent out. If you specify a
> specific reviewer, it starts the email with Hi, <name>. Which is
> weird. In general review requests are to everyone, with specific
> people that you know care about the code in question CCed.
>
I added this, as it felt a little more personal to me (yea, I know, I'm
strange).
I can cut it out again if people don't like it...

Anybody else having an opinion?

Cheers,
/Manuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20121019/6ff5d211/attachment.html>

> I added this, as it felt a little more personal to me (yea, I know, I'm
> strange).
> I can cut it out again if people don't like it...
>
> Anybody else having an opinion?
TBH I find it really creepy. It just seems fundamentally wrong (for
me, at least) for the program to be writing "Hi", which is a greeting
between *people*. It gives me the same weird feeling as if an
e-postcard service were to automatically add "Love you mom" when I
choose to send an e-postcard to my mom; it is just something which the
software doesn't seem entitled to write on my behalf.

-- Sean Silva

On Fri, Oct 19, 2012 at 4:17 PM, Manuel Klimek <klimek at google.com>
wrote:
> On Fri, Oct 19, 2012 at 1:05 AM, Michael Spencer <bigcheesegs at
gmail.com>
> wrote:
>>
>> On Wed, Oct 17, 2012 at 10:18 AM, Manuel Klimek <klimek at
google.com> wrote:
>> > Dear LLVM / Clang community,
>> >
>> > we'd like to open the use of Phabricator as an optional tool
for doing
>> > code
>> > reviews to a wider audience. Please feel free to start your code
reviews
>> > by
>> > following the documentation at
http://llvm.org/docs/Phabricator.html.
>> >
>> > Note that e-mail is still the reference medium for code reviews.
Please
>> > let
>> > me know about any problems with Phabricator or the documentation
you
>> > find.
>> >
>> > Cheers,
>> > /Manuel
>> >
>> > _______________________________________________
>> > cfe-dev mailing list
>> > cfe-dev at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> >
>>
>> One minor issue with the patch I just sent out. If you specify a
>> specific reviewer, it starts the email with Hi, <name>. Which is
>> weird. In general review requests are to everyone, with specific
>> people that you know care about the code in question CCed.
>
>
> I added this, as it felt a little more personal to me (yea, I know, I'm
> strange).
> I can cut it out again if people don't like it...
>
> Anybody else having an opinion?
>
> Cheers,
> /Manuel
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

> From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at
cs.uiuc.edu]
> On Behalf Of Sean Silva
> Subject: Re: [LLVMdev] [cfe-dev] Announcement: Phabricator for code reviews
> > Anybody else having an opinion?
> TBH I find it really creepy. It just seems fundamentally wrong (for
> me, at least) for the program to be writing "Hi", which is a
greeting
> between *people*. It gives me the same weird feeling as if an
> e-postcard service were to automatically add "Love you mom" when
I
> choose to send an e-postcard to my mom; it is just something which the
> software doesn't seem entitled to write on my behalf.
A bit like the GPP components installed by Sirius Cybernetics on the Heart of
Gold...

 - Chuck


THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you received
this in error, please contact the sender and delete the e-mail and its
attachments from all computers.