Marshall Clow
2012-May-29 17:01 UTC
[LLVMdev] NIT: Include guards for include/llvm/Support/COFF.h
The file begins:> #ifndef LLVM_SUPPORT_WIN_COFF_H > #define LLVM_SUPPORT_WIN_COFF_HWhy "WIN_COFF_H" - since this code is not windows-specific, as far as I can tell. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists at gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki
Óscar Fuentes
2012-May-29 17:39 UTC
[LLVMdev] NIT: Include guards for include/llvm/Support/COFF.h
Marshall Clow <mclow.lists at gmail.com> writes:> The file begins: > >> #ifndef LLVM_SUPPORT_WIN_COFF_H >> #define LLVM_SUPPORT_WIN_COFF_H > > Why "WIN_COFF_H" - since this code is not windows-specific, as far as > I can tell.I guess because it implements support for the COFF format on its Windows variant.
Nathan Jeffords
2012-May-29 19:52 UTC
[LLVMdev] NIT: Include guards for include/llvm/Support/COFF.h
I forget the exact details, but Microsoft's COFF is not quite standard. An this module was written specifically to target the windows platform. On Tue, May 29, 2012 at 10:01 AM, Marshall Clow <mclow.lists at gmail.com>wrote:> The file begins: > > > #ifndef LLVM_SUPPORT_WIN_COFF_H > > #define LLVM_SUPPORT_WIN_COFF_H > > Why "WIN_COFF_H" - since this code is not windows-specific, as far as I > can tell. > > -- Marshall > > Marshall Clow Idio Software <mailto:mclow.lists at gmail.com> > > A.D. 1517: Martin Luther nails his 95 Theses to the church door and is > promptly moderated down to (-1, Flamebait). > -- Yu Suzuki > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120529/41d71201/attachment.html>