llvm dev - Jun 2011 - [LLVMdev] How to identify LLVM version? [updated patch]

Hi Yuri,

On 31/05/11 22:29, Yuri wrote:
> On 05/31/2011 12:50, Duncan Sands wrote:
>> probably it's best to just go ahead and implement this (with
PACKAGE_VERSION
>> being auto-computed from these) and see if anyone objects :
>
> But this only works for C++ apps compiled with headers.
> It's better to implement version to be returned through the API
exported from
> libLLVM.so
how about both?  Patches welcome!

Ciao, Duncan.

On 06/01/2011 07:28, Duncan Sands wrote:
> how about both?  Patches welcome!
I am attaching the patch for the version to be exported through the API.

Yuri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20110602/c51ab8b7/attachment.txt>

On 06/01/2011 07:28, Duncan Sands wrote:
> how about both?  Patches welcome!
Sorry, disregard the previous patch.
Correct patch is attached.

Yuri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20110602/a49ab41c/attachment.txt>

A minor point: Make that function parameter an enum instead of a 
boolean. That would make it possible to extend the function so it 
returns other information without potentially breaking client code 
(which might pass in 1 or -1 or something entirely different to get 
repository information).

Just my 2c.

Regards,
Jo

Following the suggestions of Joachim Durchholz and Csaba Raduly, I 
submit the updated patch.

Yuri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20110603/3ab82148/attachment.txt>

On 06/03/2011 12:04, Yuri wrote:
> Following the suggestions of Joachim Durchholz and Csaba Raduly, I 
> submit the updated patch.
Could somebody check in this patch? I think it got lost in mailing lists 
llvmdev@ and llvm-commits@ and forgotten about.

Thank you,
Yuri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20110629/82939626/attachment.txt>