llvm dev - Sep 2010 - [LLVMdev] Questions on ARMInstrInfo.td and MC/ARM/ELF

On Wed, Sep 29, 2010 at 4:00 PM, Jim Grosbach <grosbach at apple.com>
wrote:
>
> On Sep 29, 2010, at 3:58 PM, Anton Korobeynikov wrote:
>
>> Hi Jim,
>>
>>> Since this is by definition only for .s file emission, why is this
clearly wrong? Perhaps it is, but it's not obvious to me why.
>> Attributes should be emitted into object file as well...
>
> Yes, but surely not by a function explicitly indicated to be for assembly
files. I would expect there to be an equivalent function to do what needs done
for object files. Perhaps there isn't one (yet) and that's what's
leading to the confusion?
LOL :-) Yes, maybe that's it. Included is a patch w comments that
explains better.

Summation:

1. Should AsmPrinter::EmitStartOfAsmFile() be always called as is now?
2. If not, where should the arch-specific code go?
3. Where should the MCStreamer specific stuff for #2 go?

Again, these are all high level design intent questions. Perhaps Mr
Lattner can opine?

Thanks!

-jason
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-mc-elf-s03-r115102.patch
Type: text/x-patch
Size: 1188 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20100929/6f016fe3/attachment.bin>

On Sep 29, 2010, at 4:27 PM, Jason Kim wrote:
>> Yes, but surely not by a function explicitly indicated to be for
assembly files. I would expect there to be an equivalent function to do what
needs done for object files. Perhaps there isn't one (yet) and that's
what's leading to the confusion?
> 
> LOL :-) Yes, maybe that's it. Included is a patch w comments that
> explains better.
> 
> Summation:
> 
> 1. Should AsmPrinter::EmitStartOfAsmFile() be always called as is now?
Yes.
> 2. If not, where should the arch-specific code go?
N/A :-)
> 3. Where should the MCStreamer specific stuff for #2 go?
I'm not sure what you mean.  The MCStreamer interface should have methods
for all possible directives that can be sent to a .s file.  The problem here has
nothing to do with text output, it is that we don't have a way to send the
".syntax unified" directive down a streamer.  The right fix is to add
this support to MCStreamer.

-Chris

On Wed, Sep 29, 2010 at 4:42 PM, Chris Lattner <clattner at apple.com>
wrote:
>
> I'm not sure what you mean.  The MCStreamer interface should have
methods for all possible directives that can be sent to a .s file.  The problem
here has nothing to do with text output, it is that we don't have a way to
send the ".syntax unified" directive down a streamer.  The right fix
is to add this support to MCStreamer.
Ahh! Okay. makes sense now. I'll send a small patch shortly.
Thanks

-jason
>
> -Chris
>
>