llvm dev - Sep 2010 - [LLVMdev] Questions on ARMInstrInfo.td and MC/ARM/ELF

Hi Jim,
> Since this is by definition only for .s file emission, why is this clearly
wrong? Perhaps it is, but it's not obvious to me why.
Attributes should be emitted into object file as well...

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

On Sep 29, 2010, at 3:58 PM, Anton Korobeynikov wrote:
> Hi Jim,
> 
>> Since this is by definition only for .s file emission, why is this
clearly wrong? Perhaps it is, but it's not obvious to me why.
> Attributes should be emitted into object file as well...
Yes, but surely not by a function explicitly indicated to be for assembly files.
I would expect there to be an equivalent function to do what needs done for
object files. Perhaps there isn't one (yet) and that's what's
leading to the confusion?

On Wed, Sep 29, 2010 at 4:00 PM, Jim Grosbach <grosbach at apple.com>
wrote:
>
> On Sep 29, 2010, at 3:58 PM, Anton Korobeynikov wrote:
>
>> Hi Jim,
>>
>>> Since this is by definition only for .s file emission, why is this
clearly wrong? Perhaps it is, but it's not obvious to me why.
>> Attributes should be emitted into object file as well...
>
> Yes, but surely not by a function explicitly indicated to be for assembly
files. I would expect there to be an equivalent function to do what needs done
for object files. Perhaps there isn't one (yet) and that's what's
leading to the confusion?
LOL :-) Yes, maybe that's it. Included is a patch w comments that
explains better.

Summation:

1. Should AsmPrinter::EmitStartOfAsmFile() be always called as is now?
2. If not, where should the arch-specific code go?
3. Where should the MCStreamer specific stuff for #2 go?

Again, these are all high level design intent questions. Perhaps Mr
Lattner can opine?

Thanks!

-jason
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-mc-elf-s03-r115102.patch
Type: text/x-patch
Size: 1188 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20100929/6f016fe3/attachment.bin>