> > Currently we don't do any unsafe-math opts in InstCombine. Not sure > if this is policy or if it's just that nobody's implemented it. >perhaps in can be implemented using the existing flag -enable-unsafe-fp-math. what do you think? -Jochen
On Jul 26, 2010, at 2:52 PMPDT, Jochen Wilhelmy wrote:>> Currently we don't do any unsafe-math opts in InstCombine. Not >> sure if this is policy or if it's just that nobody's implemented it. >> > perhaps in can be implemented using the existing flag -enable-unsafe- > fp-math. > what do you think?I don't see any good reason these opts shouldn't be in InstCombine. Last time I looked that flag wasn't easily accessible in InstCombine but it looks like that might have been fixed.
On Jul 26, 2010, at 3:22 PM, Dale Johannesen wrote: On Jul 26, 2010, at 2:52 PMPDT, Jochen Wilhelmy wrote:>>> Currently we don't do any unsafe-math opts in InstCombine. Not >>> sure if this is policy or if it's just that nobody's implemented it. >>> >> perhaps in can be implemented using the existing flag -enable-unsafe- >> fp-math. >> what do you think? > > I don't see any good reason these opts shouldn't be in InstCombine. > Last time I looked that flag wasn't easily accessible in InstCombine > but it looks like that might have been fixed.Keeping it out of the mid-level optimizers is "by design". When we tackle this, we should do it right, by making the flags per-instruction. -Chris