llvm dev - Apr 2010 - [LLVMdev] Patch - Allow calls that return i8 or i16. On SPU.

hi,

either function call in this code makes llc (targeting SPU) assert:

declare i8 @return_i8()
declare i16 @return_i16()
define void @testfunc() {
   %rv1 = call i8 @return_i8()
   %rv2 = call i16 @return_i16()
   ret void
}

Attached is a patch to fix it, and remove some related redundant code.
Does this rather trivial fix warrant a test case?

kalle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: spu_call_i8_i16.patch
Type: text/x-patch
Size: 996 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20100419/6605c8db/attachment.bin>

On Apr 19, 2010, at 2:31 AM, Kalle Raiskila wrote:
> hi,
> 
> either function call in this code makes llc (targeting SPU) assert:
> 
> declare i8 @return_i8()
> declare i16 @return_i16()
> define void @testfunc() {
>  %rv1 = call i8 @return_i8()
>  %rv2 = call i16 @return_i16()
>  ret void
> }
> 
> Attached is a patch to fix it, and remove some related redundant code.
Thanks applied here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20100419/100138.html
> Does this rather trivial fix warrant a test case?
Absolutely, and I included it in the patch above.  Please include new testcases
in the .patch file, it makes them easier to apply.  Thanks for the fixes!

-Chris
> 
> kalle
>
<spu_call_i8_i16.patch>_______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev