llvm dev - Jun 2008 - [LLVMdev] [patch] add support for PIC on linux x86-64

On Fri, 2008-06-06 at 17:08 +0100, Rafael Espindola
wrote:
> 2008/6/6 Anton Korobeynikov <asl at math.spbu.ru>:
> > Hello, Rafael
> >
> > Awesome! But... -ENOPATCH :(
> 
> Attached now.
Hi Rafael,

Thanks a lot for working on this!

I have one question about the patch; why did you choose too add a new
enum, PICCallStyle, instead of reusing (possibly with some adjustments)
the existing PICStyle enum?

Thanks,

Dan

On Jun 6, 2008, at 11:55 AM, Dan Gohman wrote:
> On Fri, 2008-06-06 at 17:08 +0100, Rafael Espindola wrote:
>> 2008/6/6 Anton Korobeynikov <asl at math.spbu.ru>:
>>> Hello, Rafael
>>>
>>> Awesome! But... -ENOPATCH :(
>>
>> Attached now.
>
> Hi Rafael,
>
> Thanks a lot for working on this!
>
> I have one question about the patch; why did you choose too add a new
> enum, PICCallStyle, instead of reusing (possibly with some  
> adjustments)
> the existing PICStyle enum?
Yes, please remove PICCallStyle and have printPLT check for pic  
relocation model and Subtarget.isTargetELF().

And where you are modifying this part of the code. Please rename  
printGOT, printStub, and printPLT to something that indicates they are  
predicate functions. Perhaps shouldPrintGOT, etc.?

Thanks,

Evan
>
>
> Thanks,
>
> Dan
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

> Yes, please remove PICCallStyle and have printPLT check for pic
> relocation model and Subtarget.isTargetELF().
Done.
> And where you are modifying this part of the code. Please rename
> printGOT, printStub, and printPLT to something that indicates they are
> predicate functions. Perhaps shouldPrintGOT, etc.?
Done.

Updated patch attached.
> Thanks,
>
> Evan
Cheers,
-- 
Rafael Avila de Espindola

Google Ireland Ltd.
Gordon House
Barrow Street
Dublin 4
Ireland

Registered in Dublin, Ireland
Registration Number: 368047
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86-64-plt.patch
Type: application/octet-stream
Size: 8097 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20080607/d5bb2043/attachment.obj>