search for: piccallstyl

...spindola wrote: > 2008/6/6 Anton Korobeynikov <asl at math.spbu.ru>: > > Hello, Rafael > > > > Awesome! But... -ENOPATCH :( > > Attached now. Hi Rafael, Thanks a lot for working on this! I have one question about the patch; why did you choose too add a new enum, PICCallStyle, instead of reusing (possibly with some adjustments) the existing PICStyle enum? Thanks, Dan

...<asl at math.spbu.ru>: >>> Hello, Rafael >>> >>> Awesome! But... -ENOPATCH :( >> >> Attached now. > > Hi Rafael, > > Thanks a lot for working on this! > > I have one question about the patch; why did you choose too add a new > enum, PICCallStyle, instead of reusing (possibly with some > adjustments) > the existing PICStyle enum? Yes, please remove PICCallStyle and have printPLT check for pic relocation model and Subtarget.isTargetELF(). And where you are modifying this part of the code. Please rename printGOT, printStub, and...

I have been playing a bit with LLVM again and it looks like the current major missing feature on Linux x86-64 is PIC. Is anyone working on it? If not, I would like to do so. I have the ABI documentation (http://www.x86-64.org/documentation/abi.pdf), but would be glad if someone had some LLVM specific pointers. For example, from the targets that do have support for PIC, which one is the one to be

...nit), variables > can just use RIP relative access. Right, this is just optimization. AFAIR, current code already does this for 'normal' PIC - it just checks for linkage and doesn't assemble call via PLT for stuff with internal linkage. > Looks like we need a second variable (say PICCallStyle). With it we > would have something like: This seems to be PIC vs Dynamic-No-PIC relocation style issue, I don't see, why something new is needed here. -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University.

Hello, Rafael > With this patch I was able to bootstrap gcc in linux x86-64 with > shared libraries enabled :-) Awesome! But... -ENOPATCH :( -- With best regards, Anton Korobeynikov. Faculty of Mathematics & Mechanics, Saint Petersburg State University.

2008/6/6 Anton Korobeynikov <asl at math.spbu.ru>: > Hello, Rafael > > Awesome! But... -ENOPATCH :( Attached now. Thanks, -- Rafael Avila de Espindola Google Ireland Ltd. Gordon House Barrow Street Dublin 4 Ireland Registered in Dublin, Ireland Registration Number: 368047 -------------- next part -------------- A non-text attachment was scrubbed... Name: x86-64-plt.patch Type:

> Yes, please remove PICCallStyle and have printPLT check for pic > relocation model and Subtarget.isTargetELF(). Done. > And where you are modifying this part of the code. Please rename > printGOT, printStub, and printPLT to something that indicates they are > predicate functions. Perhaps shouldPrintGOT, etc.? Done...